GH-400, GH-401 Upgrading JWT Library to V4 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 29, 2021
This was referenced Sep 29, 2021
Closed
Closed
|
@andygrunwald @ghostsquad Looks like this upgrade may break pre-1.15 support. Are we ok with that? |
benjivesterby
force-pushed
the
GH-401
branch
3 times, most recently
from
33e1d88
to
9982768
Compare
Adding 1.16.x and 1.17.x tests to matrix updated to go 1.15 min
benjivesterby
force-pushed
the
GH-401
branch
from
9982768
to
0f2d8b8
Compare
andygrunwald
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
For me, breaking compatibility before go 1.15 is ok. Mainly because the current supported go versions are 1.15, 1.16, and 1.17.
We should follow the release cycle for the language.
The PR looks good. Thanks for taking care. I will move on and merge it.
About the request_legacy.go and request_context.go, we should think about dropping it at some point.
|
can anybody update new tags or release version to v1.15.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded JWT library to v4 which now has module support as well as resolves security issues listed in GH-400, and GH-401