Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#400 update go.mod #402

Closed

Conversation

sitikanthasezzle
Copy link

Update jwt-go library from dgrijalva/jwt-go to form3tech-oss/jwt-go
#400

@sitikanthasezzle sitikanthasezzle changed the title #401 update go.mod #400 update go.mod Sep 29, 2021
@benjivesterby
Copy link
Collaborator

The correct import is https://github.com/golang-jwt/jwt according to the README this is where maintainership was migrated to.

@@ -4,7 +4,7 @@ go 1.12

require (
github.com/fatih/structs v1.1.0
github.com/golang-jwt/jwt v3.2.1+incompatible
github.com/form3tech-oss/jwt-go v3.2.1+incompatible
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository is archived. According to the readme from dgrijalva/jwt-go the correct maintenance of this repository was moved to github.com/golang-jwt/jwt so the current import is correct.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/andygrunwald/go-jira@v1.13.0 requires\n\tgithub.com/dgrijalva/jwt-go@v3.2.0+incompatible: missing go.sum entry; to add it:\n\tgo mod download github.com/dgrijalva/jwt-go\n

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting this error @benjivesterby

Copy link
Collaborator

@benjivesterby benjivesterby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address comment

@benjivesterby
Copy link
Collaborator

Based on comments in the dependabot PR this needs to be upgraded to V4. I've put in a PR for the upgrade #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants