Reservation Rate excel export #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
HotStew
force-pushed
the
reservation-excel-export
branch
4 times, most recently
from
611fb14
to
c65626e
Compare
tuomas777
reviewed
Mar 4, 2022
HotStew
force-pushed
the
reservation-excel-export
branch
from
c65626e
to
5bed312
Compare
|
Most of the tests that were failing were due to a translation mismatch. So nothing critical and doesn't have to be bothered with in this PR. I did however remove another test that was failing due to code changes from a ~year ago that made the test void. |
HotStew
force-pushed
the
reservation-excel-export
branch
from
37df651
to
5293c56
Compare
frwickst
approved these changes
Mar 16, 2022
added 2 commits
April 4, 2022 13:21
Add new endpoint where you can download an excel report that contains a separate sheet for each unit. Each sheet will have a summary that contains unit name, time filters, reservation rate. Below summary a list of resources with their sums of reserved time per each resource. Below this will be listings of reservation details per resource. The endpoint will take parameters that will be used for filtering the queries. Required filters are: list of units, begin date and end date. Times are optional, but will default to 08:00 and 16:00. Create serializers for the purpose of having a simple top-down data structure. Use the BaseReport base class for the new view. Create a custom excel renderer.
Test kept failing due to it testing that an exception should be raised. But the code that it tests is now wrapped in a try except block which swallows the raised exception so it can not be passed to the test.
HotStew
force-pushed
the
reservation-excel-export
branch
from
5293c56
to
eefaf92
Compare
|
Added translations to API error messages for fields that the user selects on the frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are well documented in commit messages and code!
Not to be merged quite yet!
To be done:
See frontend PR: City-of-Helsinki/huvaja#338
Example of generated excel file.