Reservation rate excel report #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HotStew
force-pushed
the
reservation-rate-excel-report
branch
from
681199a
to
6874a42
Compare
2 tasks
added 2 commits
March 9, 2022 19:10
Create the action for fetching the reservation rate report excel. Also add extensions for filenames for all report actions and modify the downloadReport function to not append .docx to filename anymore. This had to be done because all previous reports are .docx but this new one is xlsx.
Conditionally render datepicker in DateTimeRange component. Defaults to always rendering it unless specifying not to render it in controlprops. The Time range part of the DateTimeRange component is nice and useful, so now basically you are able to just render that part.
HotStew
force-pushed
the
reservation-rate-excel-report
branch
2 times, most recently
from
f77c422
to
0f5e550
Compare
frwickst
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Overall this is looking good. I would have prefered having the DateTime component be split up into two different components, since having something called DateTime and then you might only render a Date component can be strange to a developer.
But since I don't know how much refactoring work that would require in this case, I will not require that now.
Just a few things that would be good to check before merging this :)
Good work!
app/shared/modals/reservation-rate-report/ReservationsRateReport.js
Outdated
Show resolved
Hide resolved
app/shared/modals/reservation-rate-report/ReservationsRateReportContainer.js
Outdated
Show resolved
Hide resolved
frwickst
requested changes
Mar 16, 2022
HotStew
force-pushed
the
reservation-rate-excel-report
branch
from
0f5e550
to
8e9efab
Compare
|
I'd also like an opinion/input on the resetting modal state I mentioned in the PR description. |
|
The warning messages below are due to package called See: |
So the problem is that when the modal is closed the previous state inputted there persist instead of resetting the values? |
added 4 commits
April 12, 2022 11:17
Create actions reducers and selectors for Modal.
Create component ReservationRateReportModal. This modal lies in the /reservations page and can be unhidden/shown in the dropdown of <Lataa Raportti> -> Varausasteraportti. This modal will take the basic props the modal itself requires along with units and the action which downloads the report. Within the modal there are fields where the user can select/ input data: Units, Date range and Time range. Unit seletion field is a Typeahead component which is also a new package. Lastly there is the download button which when clicked, will call the api action to download the report.
Errors were mostly due to incorrect proptyping
Install node-sass that is compatible with node version 14.X.X Add a css loader for testing.
HotStew
force-pushed
the
reservation-rate-excel-report
branch
from
8e9efab
to
df247f4
Compare
frwickst
approved these changes
Apr 12, 2022
frwickst
approved these changes
Apr 12, 2022
joonvena
approved these changes
Apr 12, 2022
HotStew
force-pushed
the
reservation-rate-excel-report
branch
from
e3e150d
to
df247f4
Compare
joonvena
approved these changes
Apr 21, 2022
HotStew
force-pushed
the
reservation-rate-excel-report
branch
from
ceaf600
to
df247f4
Compare
Remove travis.yml for now so we can merge PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created capability of downloading the new reservations rate excel report.
Backend PR: andersinno/respa#52
To be done
My components somewhat differ from other components in that my have their own state defined within the components. I don't have too much experience with how things are done in this project with the reducers and the selectors so maybe having their own state is wrong?
Modal location
Unhidden modal with some initial data.
Input some data
Clicking download downloads report
Correct filters in excel file