Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest 28 support #296

Closed
bendehghan opened this issue Apr 28, 2022 · 9 comments
Closed

Jest 28 support #296

bendehghan opened this issue Apr 28, 2022 · 9 comments

Comments

@bendehghan
Copy link

Hi guys,
When do you think you'll add support for the new jest version?
Thanks,
Ben
@afc163
Copy link

afc163 commented Apr 29, 2022 •
edited

+1

图片

@ba32107
Copy link

ba32107 commented May 2, 2022

+1 please

@Rendez
Copy link

Rendez commented May 3, 2022

+1

aarongoldenthal added a commit to aarongoldenthal/jest-image-snapshot that referenced this issue May 5, 2022
@aarongoldenthal
chore: upgrade jest to v28 (americanexpress#296)
8200bfe
aarongoldenthal added a commit to aarongoldenthal/jest-image-snapshot that referenced this issue May 5, 2022
@aarongoldenthal
chore: upgrade jest to v28 (americanexpress#296)
46079ff
This was referenced May 5, 2022
Open
Merged
@bendehghan
Copy link
Author

Guys, any update on this would help. Thanks :)
Is the PR blocked for a reason other than not having been reviewed?

@AnderssonPeter
Copy link

It would be great if this would be resolved!

@bendehghan
Copy link
Author

are we any closer to this?

Thanks

JAdshead pushed a commit that referenced this issue May 30, 2022
@aarongoldenthal
chore(jest): upgrade v28
a902a5b 
BREAKING CHANGE: drop support for Node 10 due
to jest use of globalThis in Node 12

* chore: upgrade jest to v28 (#296)

* fix: drop Node 10 tests for compatibility with jest v28

* fix: update node versions to match jest

* fix: remove tests for end-of-life node releases
oneamexbot added a commit that referenced this issue May 30, 2022
@oneamexbot
chore(release): 5.0.0 [skip ci]
c86f75e 
# [5.0.0](v4.5.1...v5.0.0) (2022-05-30)

### chore

* **jest:** upgrade v28 ([a902a5b](a902a5b)), closes [#296](#296)

### BREAKING CHANGES

* **jest:** drop support for Node 10 due
to jest use of globalThis in Node 12
@JAdshead
Copy link
Contributor

Closing as this was resolved in the 5.0.0 release. Thank you @aarongoldenthal for the contribution

@ba32107
Copy link

ba32107 commented Jun 19, 2022

Would it be possible to update the corresponding type definition too?
https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jest-image-snapshot

@10xLaCroixDrinker
Copy link
Member

@ba32107 feel free to open the PR

goverdhan07 pushed a commit to goverdhan07/jest-image-snapshot that referenced this issue Jul 23, 2023
@aarongoldenthal
chore(jest): upgrade v28
995aa16 
BREAKING CHANGE: drop support for Node 10 due
to jest use of globalThis in Node 12

* chore: upgrade jest to v28 (americanexpress#296)

* fix: drop Node 10 tests for compatibility with jest v28

* fix: update node versions to match jest

* fix: remove tests for end-of-life node releases
goverdhan07 pushed a commit to goverdhan07/jest-image-snapshot that referenced this issue Jul 23, 2023
@oneamexbot
chore(release): 5.0.0 [skip ci]
b5bc6bf 
# [5.0.0](americanexpress/jest-image-snapshot@v4.5.1...v5.0.0) (2022-05-30)

### chore

* **jest:** upgrade v28 ([a902a5b](americanexpress@a902a5b)), closes [americanexpress#296](americanexpress#296)

### BREAKING CHANGES

* **jest:** drop support for Node 10 due
to jest use of globalThis in Node 12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Rendez @bendehghan @afc163 @10xLaCroixDrinker @AnderssonPeter @JAdshead @ba32107