Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

chore: upgrade jest to v28 (#296) #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: upgrade jest to v28 (#296) #1

wants to merge 4 commits into from

Conversation

aarongoldenthal
Copy link
Owner

@aarongoldenthal aarongoldenthal commented May 5, 2022

Description

Update jest and associated jest dependencies to v28.

BREAKING CHANGE: Required dropping Node 10 support since jest dropped support and now uses globalThis, which is only available in Node >=12.0.0 (see actions log with Node 10 failure). For consistency, updated engines.node to mirror jest (^12.13.0 || ^14.15.0 || ^16.10.0 || >=17.0.0), which includes leaving Node 12 compatibility (even though it went end-of-life on 2022-04-30). Also updated tests actions to drop Node 10 and add Node 17 and 18.

I did not notice any Jest v28 breaking changes, other than dropping support for Node 10, that appeared to be impacting (but did not read every line of the CHANGELOG).

Motivation and Context

Enable compatibility with latest jest release (americanexpress#296).

How Has This Been Tested?

Tests actions ran successfully for all Node versions. Performed limited testing locally on one existing project to demonstrate visual test failure and generation of diff output (Win 10 21H1, Node 16.15.0).

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Jest-Image-Snapshot?

Enable support for Jest 28. Drop support for Node 10. Add tests for Node 17 and 18.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant