chore: upgrade jest to v28 (#296) #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: drop support for Node 10 due to jest use of globalThis in Node 12
code-forger
reviewed
May 5, 2022
|
+1 |
afc163
approved these changes
May 7, 2022
|
@code-forger I believe I captured all of your comments, but let me know if there's anything else I can do to help move this along. |
|
waiting on this... |
10xLaCroixDrinker
approved these changes
May 25, 2022
JAdshead
approved these changes
May 30, 2022
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update jest and associated jest dependencies to v28.
BREAKING CHANGE: Required dropping Node 10 support since jest dropped support and now uses
globalThis, which is only available in Node >=12.0.0 (see actions log with Node 10 failure). For consistency, updatedengines.nodeto mirrorjest(^12.13.0 || ^14.15.0 || ^16.10.0 || >=17.0.0), which includes leaving Node 12 compatibility (even though it went end-of-life on 2022-04-30). Also updatedtestsactions to drop Node 10 and add Node 17 and 18.I did not notice any Jest v28 breaking changes, other than dropping support for Node 10, that appeared to be impacting (but did not read every line of the CHANGELOG).
Motivation and Context
Enable compatibility with latest jest release (#296).
How Has This Been Tested?
Tests actions ran successfully for all Node versions. Performed limited testing locally on one existing project to demonstrate visual test failure and generation of diff output (Win 10 21H1, Node 16.15.0).
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?
Enable support for Jest 28. Drop support for Node 10. Add tests for Node 17 and 18.