Added a new stub for attempting to delete a missing asset #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanb-gds
force-pushed
the
add-delete-asset-404-stub
branch
from
3771916
to
003a9f2
Compare
brucebolt
reviewed
Apr 11, 2024
This is needed for testing how publishing applications react to attempting to delete a missing asset. At the moment they are not handling not found errors, meaning that the state of the publishing application remains out of sync with asset manager and causing other logical issues. This commit also adds some test coverage for other asset deletion stubs and makes byebug available in the testing runtime.
ryanb-gds
force-pushed
the
add-delete-asset-404-stub
branch
from
003a9f2
to
316621f
Compare
There doesn't appear to be any unreleased code currently, so I've added the section at the top, hope that's appropriate. Would this constitute a patch or minor release? I'm inclined to suggest the latter as it seems to me it's offering a new feature |
|
I'm happy with the code here as well. I'm inclined to agree with you that this is probably a minor release, I initially misread the PR description and thought this was a bug fix but that doesn't appear to be the case. |
callumknights
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for testing how publishing applications react to attempting to delete a missing asset. At the moment some of them are not handling not found errors, meaning that the state of the publishing application remains out of sync with asset manager. This causes other logical issues such as being unable to discard a draft in Specialist Publisher because there is an attachment that can't be deleted.
This commit also adds some test coverage for other asset deletion stubs.