Allow deletion of attachments where the asset does not exist in Asset Manager #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanb-gds
force-pushed
the
permit-deletion-of-attachments-missing-from-asset-manager
branch
from
5cdc6e4
to
039d430
Compare
ryanb-gds
force-pushed
the
permit-deletion-of-attachments-missing-from-asset-manager
branch
from
039d430
to
6637266
Compare
… manager An attachment which does not have a corresponding asset in Asset Manager is effectively broken. Prior to this commit, it wasn't possible for users to delete these broken attachments. Being unable to delete the broken attachments prevents users from discarding any draft documents associated with them. To resolve this, we return a boolean "true" from the Attachment#destroy method when the asset cannot be found, as to all intents and purposes the asset is deleted anyway. It is not clear how the asset has been removed from Asset Manager whilst the attachment is still present.
ryanb-gds
force-pushed
the
permit-deletion-of-attachments-missing-from-asset-manager
branch
from
6637266
to
83ed8c9
Compare
lauraghiorghisor-tw
approved these changes
Apr 30, 2024
ryanb-gds
deleted the
permit-deletion-of-attachments-missing-from-asset-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attachment which does not have a corresponding asset in Asset Manager is effectively broken. Prior to this commit, it wasn't possible for users to delete these broken attachments.
Being unable to delete the broken attachments prevents users from discarding any draft documents associated with them.
To resolve this, we return a boolean "true" from the Attachment#destroy method when the asset cannot be found, as to all intents and purposes the asset is deleted anyway.
I haven't included a feature test for this as it feels like an edge case that is not valuable enough to cover with an expensive feature test.
It is not clear how the asset has been removed from Asset Manager whilst the attachment is still present.
Trello: https://trello.com/c/epa4vl02
Depends on alphagov/gds-api-adapters#1248 to be merged