p2p: test scenarios support #12996
algorandskiyreviewdog.yml
on: pull_request
reviewdog-errors
4m 11s
reviewdog-warnings
1m 37s
Annotations
6 errors and 2 warnings
|
reviewdog-errors:
network/p2pNetwork.go#L766
[Lint Errors] reported by reviewdog 🐶
Error return value of `stream.SetWriteDeadline` is not checked (errcheck)
Raw Output:
network/p2pNetwork.go:766:25: Error return value of `stream.SetWriteDeadline` is not checked (errcheck)
stream.SetWriteDeadline(yamux.HighPriorityWriteDeadlineMagicValue)
^
|
|
reviewdog-errors:
network/p2p/mux.go#L33
[Lint Errors] reported by reviewdog 🐶
exported: exported var DefaultTransport should have comment or be unexported (revive)
Raw Output:
network/p2p/mux.go:33:5: exported: exported var DefaultTransport should have comment or be unexported (revive)
var DefaultTransport *Transport
^
|
|
reviewdog-errors:
network/p2p/mux.go#L35
[Lint Errors] reported by reviewdog 🐶
exported: exported const ID should have comment or be unexported (revive)
Raw Output:
network/p2p/mux.go:35:7: exported: exported const ID should have comment or be unexported (revive)
const ID = "/yamux/1.0.0"
^
|
|
reviewdog-errors:
network/p2p/mux.go#L62
[Lint Errors] reported by reviewdog 🐶
exported: exported method Transport.NewConn should have comment or be unexported (revive)
Raw Output:
network/p2p/mux.go:62:1: exported: exported method Transport.NewConn should have comment or be unexported (revive)
func (t *Transport) NewConn(nc net.Conn, isServer bool, scope network.PeerScope) (network.MuxedConn, error) {
^
|
|
reviewdog-errors:
network/p2p/mux.go#L81
[Lint Errors] reported by reviewdog 🐶
exported: exported method Transport.Config should have comment or be unexported (revive)
Raw Output:
network/p2p/mux.go:81:1: exported: exported method Transport.Config should have comment or be unexported (revive)
func (t *Transport) Config() *yamux.Config {
^
|
|
reviewdog-errors
reviewdog exited with status code: 1
|
|
reviewdog-warnings
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3.5.3, actions/setup-go@v4.0.1, actions/cache@v3.3.1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
reviewdog-errors
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3.5.3, reviewdog/action-golangci-lint@v2.3.1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|