Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: test scenarios support #5962

Open
wants to merge 43 commits into
base: feature/p2p
Choose a base branch
from

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Mar 18, 2024

Summary

  • add P2PBootstrap netdeploy's template option
  • add p2p dnsadddr support to netdeploy
  • add scenario1s-p2p, hello-word-tiny-p2p, hello-world-small-p2p
  • fixes to p2p telemetry
  • added missed gossipSubPeer.RoutingAddr implementation
  • make libp2 logger to log into node.log by implementing zapcore.Core writing via logger.Logger
    Example log records
{
    "file": "github.com/libp2p/go-libp2p@v0.32.2/config/config.go",
    "function": "github.com/libp2p/go-libp2p/config.(*Config).NewNode",
    "level": "warning",
    "line": 304,
    "msg": "rcmgr limit conflicts with connmgr limit: conn manager high watermark limit: 192, exceeds the system connection limit of: 1",
    "name": "127.0.0.1:0",
    "libp2p": "p2p-config",
    "time": "2024-04-17T19:43:31.640497-04:00"
}
{
    "file": "github.com/libp2p/go-libp2p-pubsub@v0.10.0/pubsub.go",
    "function": "github.com/libp2p/go-libp2p-pubsub.(*PubSub).processLoop",
    "level": "info",
    "line": 671,
    "msg": "pubsub processloop shutting down",
    "name": "127.0.0.1:0",
    "libp2p": "pubsub",
    "time": "2024-04-17T19:43:36.354601-04:00"
}

Test Plan

  • Ran scenarios, ensured progress
  • Deployed networks, collected/analyzed regular performance metrics - 2.2k TPS on scenario1s

@algorandskiy algorandskiy added Enhancement p2p Work related to the p2p project labels Mar 18, 2024
@algorandskiy algorandskiy self-assigned this Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 53.52113% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 56.02%. Comparing base (411837f) to head (f1f03a7).

Files Patch % Lines
network/p2p/logger.go 0.00% 41 Missing ⚠️
network/p2p/mux.go 78.12% 11 Missing and 3 partials ⚠️
network/p2pNetwork.go 69.56% 7 Missing ⚠️
logging/log.go 0.00% 2 Missing ⚠️
network/p2p/http.go 0.00% 1 Missing ⚠️
network/p2p/streams.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           feature/p2p    #5962    +/-   ##
=============================================
  Coverage        56.01%   56.02%            
=============================================
  Files              495      497     +2     
  Lines            69009    69130   +121     
=============================================
+ Hits             38657    38731    +74     
- Misses           27730    27774    +44     
- Partials          2622     2625     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy force-pushed the pavel/p2p-scenarios branch 4 times, most recently from 69cb867 to a5ccfcb Compare April 2, 2024 20:15
@algorandskiy algorandskiy requested a review from cce April 17, 2024 23:29
@algorandskiy algorandskiy force-pushed the pavel/p2p-scenarios branch 2 times, most recently from 3a7e767 to 79251d0 Compare April 19, 2024 21:31
@algorandskiy algorandskiy changed the title WIP: p2p: test scenarios support p2p: test scenarios support Apr 20, 2024
@algorandskiy algorandskiy marked this pull request as ready for review April 20, 2024 00:12
@@ -0,0 +1,66 @@
"""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is to have it dependency-free so it can be run on a remote machine with logs

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 85 lines in your changes missing coverage. Please review.

Project coverage is 56.03%. Comparing base (411837f) to head (e105157).

Files Patch % Lines
network/p2p/logger.go 0.00% 41 Missing ⚠️
network/p2p/mux.go 78.12% 11 Missing and 3 partials ⚠️
network/p2pNetwork.go 64.10% 10 Missing and 4 partials ⚠️
network/p2p/p2p.go 14.28% 6 Missing ⚠️
network/p2p/streams.go 0.00% 4 Missing ⚠️
config/localTemplate.go 0.00% 3 Missing ⚠️
logging/log.go 0.00% 2 Missing ⚠️
network/p2p/http.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           feature/p2p    #5962      +/-   ##
===============================================
+ Coverage        56.01%   56.03%   +0.01%     
===============================================
  Files              495      497       +2     
  Lines            69009    69143     +134     
===============================================
+ Hits             38657    38742      +85     
- Misses           27730    27779      +49     
  Partials          2622     2622              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement p2p Work related to the p2p project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants