Update to chunk.mapModules #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chunk.modules is deprecated in Webpack 3.0.0 - replaced with the mapModules method. Added with fallback, to support Webpack 2.0.0
|
Thanks for the PR. I'm curious if mapModules have the same structure or there are more changes needed to be done to support webpack 3? |
This was referenced Jul 15, 2017
|
This is safe to merge - see a similar fix in extract-webpack-text-plugin: https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/553/files#diff-1fdf421c05c1140f6d71444ea2b27638R148 The change (webpack/webpack#4764) was just done for performance - and the Our test suite for webpack-encore also passes with this change :). +1! |
|
Friendly ping! :) |
weaverryan
added a commit
to symfony/webpack-encore
that referenced
this pull request
Sep 2, 2017
This PR was merged into the master branch. Discussion ---------- Intercept Webpack output during functional tests This PR replaces `process.stdout.write` by an empty function when running webpack in each functional test (fixes #47). It also sets the `silent` option of the Zombie.js browser to true to avoid displaying things like: ``` Download the Vue Devtools extension for a better development experience: https://github.com/vuejs/vue-devtools You are running Vue in development mode. Make sure to turn on production mode when deploying for production. See more tips at https://vuejs.org/guide/deployment.html ``` The only "noisy" message left should be `DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead` since it is sent to stderr (should be fixed when alexindigo/webpack-chunk-hash#9 is released). Commits ------- a74869b Intercept output during functional tests (fixes #47)
|
Ping! Could you tag a new release? We haven’t been able to enjoy this update yet :) |
|
@weaverryan I published |
|
No worries - thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunk.modules is deprecated in Webpack 3.0.0 - replaced with the mapModules method.
Added with fallback, to support Webpack 2.0.0