Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack 3.1 deprecation warning #91

Closed
weaverryan opened this issue Jul 13, 2017 · 5 comments
Closed

Webpack 3.1 deprecation warning #91

weaverryan opened this issue Jul 13, 2017 · 5 comments

Comments

@weaverryan
Copy link
Member

#53 moved us to Webpack 3.1 without any issues.

But, we do have 1 deprecation we should fix before releasing:

(node:32501) DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.

This comes from the addStyleEntry .js files are removed functional test.
@weaverryan weaverryan changed the title Webpack 3.1 deprecation Webpack 3.1 deprecation warning Jul 13, 2017
@weaverryan
Copy link
Member Author

See: alexindigo/webpack-chunk-hash#9

@garak
Copy link

garak commented Sep 5, 2017

It looks like related PR was merged... what about encore?

@stof
Copy link
Member

stof commented Sep 5, 2017

Well, they merged the PR, but they have not released the fix. And npm does not use dev versions like Composer allows you to do (which is totally logical given that the npm registry also stores the code, not only the metadata).
So as far as npm is concerned, the bugfix does not exist yet.

@binarious
Copy link

It has been released: alexindigo/webpack-chunk-hash#9 (comment)

@Lyrkan
Copy link
Collaborator

Lyrkan commented Oct 13, 2017

@weaverryan Reopening: the current version range declared in the package.json file for webpack-chunk-hash (^0.4.0) does not allow to install the new version (0.5.0).

@Lyrkan Lyrkan reopened this Oct 13, 2017
@Lyrkan Lyrkan mentioned this issue Oct 13, 2017
Merged
weaverryan added a commit that referenced this issue Oct 14, 2017
@weaverryan
bug #182 Upgrade webpack-chunk-hash dependency (Lyrkan)
e83df32 
This PR was merged into the master branch.

Discussion
----------

Upgrade webpack-chunk-hash dependency

Fixes #91 by using `webpack-chunk-hash@^0.5.0` instead of `webpack-chunk-hash@^0.4.0` ([caret ranges](https://yarnpkg.com/lang/en/docs/dependency-versions/#toc-caret-ranges) don't allow to change the first non-zero digit).

Commits
-------

993fabb Upgrade webpack-chunk-hash dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@weaverryan @garak @binarious @stof @Lyrkan