Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChannelExecutor configuration backward compatibility problem #5568

Merged
merged 3 commits into from Feb 7, 2022
Merged

Fix ChannelExecutor configuration backward compatibility problem #5568

merged 3 commits into from Feb 7, 2022

Conversation

Arkatufus
Copy link
Contributor

Fixes #5541

Changes

Make sure that channel-executor configuration is injected properly when it is missing

Aaronontheweb
Aaronontheweb approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/Akka/Dispatch/ChannelSchedulerExtension.cs Outdated Show resolved Hide resolved
@Aaronontheweb Aaronontheweb merged commit 261910e into akkadotnet:dev Feb 7, 2022
@Aaronontheweb Aaronontheweb mentioned this pull request Feb 14, 2022
Merged
This was referenced Feb 23, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

@Zetanova Zetanova Zetanova left review comments

@eaba eaba eaba left review comments

Assignees
No one assigned
Labels
akka-actor configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-documented breaking change of channel-executor configuration
4 participants
@Arkatufus @Aaronontheweb @Zetanova @eaba