Channel executor not injected

[eaba]

Fixes #5541

Changes

From var config = system.Settings.Config.GetConfig("akka.channel-scheduler"); to var config = system.Settings.Config.GetConfig("akka.actor.channel-scheduler");

• I have reviewed my own pull request.
• Design discussion issue Non-documented breaking change of channel-executor configuration #5541

[eaba]

channel-executor not injected when channel-executor.priority is not explicitly set by user @Zetanova @Aaronontheweb

akka.net/src/core/Akka/Dispatch/AbstractDispatcher.cs

Line 123 in 405dfc5

var cfg = config.GetConfig("channel-executor");

[Zetanova]

I made already some improvements to config loading in PR #5515

The channel-scheduler is a standalone component and akka.channel-scheduler is correct,
but I copied the default config block into the wrong place in the default config:

akka.net/src/core/Akka/Configuration/Pigeon.conf

Lines 272 to 279 in 405dfc5

	channel-scheduler {
	parallelism-min = 4 #same as for ForkJoinDispatcher
	parallelism-factor = 1 #same as for ForkJoinDispatcher
	parallelism-max = 64 #same as for ForkJoinDispatcher
	work-max = 10 #max executed work items in sequence until priority loop
	work-interval = 500 #time target of executed work items in ms
	work-step = 2 #target work item count in interval / burst
	}

Please change the default config in Pigeon.conf and not akka.channel-scheduler

[Arkatufus]

This fact needs to be documented properly, it does not reflect what we have right now in the documentation here:
https://getakka.net/articles/actors/dispatchers.html#channelexecutor

[Arkatufus]

Need to add these codes here: https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka/Configuration/Pigeon.conf#L354

channel-executor {
  priority = normal
}

[Arkatufus]

Also need to document these enum values in the code above: https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka/Dispatch/ChannelSchedulerExtension.cs#L456-L467

[Aaronontheweb]

Also need to document these enum values in the code above: https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka/Dispatch/ChannelSchedulerExtension.cs#L456-L467

The fact that Idle and Background are set for the same value - does that seem like a mistake?

[Zetanova]

I put only all names from windows process priority into the enum
They can be used but only have the same effect.

See:
#5543 (comment)

[Arkatufus]

I can't merge this, it still doesn't address the original issue

[eaba]

I can't merge this, it still doesn't address the original issue

Yes @Arkatufus it does not. This was like showing what the issue was and luckily @Zetanova already created a PR that addresses that! We can actually close this, right? @Aaronontheweb

[Arkatufus]

No, his PR does not address this issue.

[eaba]

at Akka.Dispatch.ChannelExecutorConfigurator..ctor(Config config, IDispatcherPrerequisites prerequisites) in D:\a\1\s\src\core\Akka\Dispatch\AbstractDispatcher.cs:line 124

   at Akka.Dispatch.MessageDispatcherConfigurator.ConfigureExecutor() in D:\a\1\s\src\core\Akka\Dispatch\AbstractDispatcher.cs:line 327

   at Akka.Dispatch.DispatcherConfigurator..ctor(Config config, IDispatcherPrerequisites prerequisites) in D:\a\1\s\src\core\Akka\Dispatch\Dispatchers.cs:line 590

   at Akka.Dispatch.Dispatchers.ConfiguratorFrom(Config cfg) in D:\a\1\s\src\core\Akka\Dispatch\Dispatchers.cs:line 535

   at Akka.Dispatch.Dispatchers.LookupConfigurator(String id) in D:\a\1\s\src\core\Akka\Dispatch\Dispatchers.cs:line 439

   at Akka.Dispatch.Dispatchers..ctor(ActorSystem system, IDispatcherPrerequisites prerequisites, ILoggingAdapter logger) in D:\a\1\s\src\core\Akka\Dispatch\Dispatchers.cs:line 342

   at Akka.Actor.Internal.ActorSystemImpl.ConfigureDispatchers() in D:\a\1\s\src\core\Akka\Actor\Internal\ActorSystemImpl.cs:line 470

   at Akka.Actor.Internal.ActorSystemImpl..ctor(String name, Config config, ActorSystemSetup setup, Nullable`1 guardianProps) in D:\a\1\s\src\core\Akka\Actor\Internal\ActorSystemImpl.cs:line 102

   at Akka.Actor.ActorSystem.CreateAndStartSystem(String name, Config withFallback, ActorSystemSetup setup) in D:\a\1\s\src\core\Akka\Actor\ActorSystem.cs:line 281

   at Akka.Tests.Dispatch.ChannelExecutorSpec.Should_Successfully_Create_Channel_Executor_ActorSystem() in D:\a\1\s\src\core\Akka.Tests\Dispatch\ChannelExecutorSpec.cs:line 19

[Aaronontheweb]

The real issue here is that the old channel-executor HOCON still needs to work, but right now it doesn't. We need to add a backwards compat spec and make sure the old HOCON can cause the system to load the new code.

[Zetanova]

I

The real issue here is that the old channel-executor HOCON still needs to work, but right now it doesn't. We need to add a backwards compat spec and make sure the old HOCON can cause the system to load the new code.

@Aaronontheweb The config section of channel-scheduler was placed in the wrong section akka.actor the Pigeon.conf
it was always intended to be in akka section directly and in every post with a config example it is under akka.channel-scheduler

[Arkatufus]

Superseeded by #5568