-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scala.concurrent.Batchable for Scala 2.13 #29986
Merged
johanandren
merged 3 commits into
akka:master
from
johanandren:wip-29980-oncompleterunnable-batchable
Mar 1, 2021
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
akka-actor/src/main/scala-2.12/akka/dispatch/internal/ScalaBatchable.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/* | ||
* Copyright (C) 2009-2021 Lightbend Inc. <https://www.lightbend.com> | ||
*/ | ||
|
||
package akka.dispatch.internal | ||
|
||
import akka.annotation.InternalApi | ||
|
||
/** | ||
* INTERNAL API | ||
*/ | ||
@InternalApi | ||
private[akka] object ScalaBatchable { | ||
|
||
// see Scala 2.13 source tree for explanation | ||
def isBatchable(runnable: Runnable): Boolean = runnable match { | ||
case b: akka.dispatch.Batchable => b.isBatchable | ||
case _: scala.concurrent.OnCompleteRunnable => true | ||
case _ => false | ||
} | ||
|
||
} |
28 changes: 28 additions & 0 deletions
28
akka-actor/src/main/scala-2.13/akka/dispatch/internal/ScalaBatchable.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/* | ||
* Copyright (C) 2009-2021 Lightbend Inc. <https://www.lightbend.com> | ||
*/ | ||
|
||
package akka.dispatch.internal | ||
|
||
import akka.annotation.InternalApi | ||
|
||
/** | ||
* INTERNAL API | ||
*/ | ||
@InternalApi | ||
private[akka] object ScalaBatchable { | ||
|
||
/* | ||
* In Scala 2.13.0 `OnCompleteRunnable` was deprecated, and in 2.13.4 | ||
* `impl.Promise.Transformation` no longer extend the deprecated `OnCompleteRunnable` | ||
* but instead `scala.concurrent.Batchable` (which anyway extends `OnCompleteRunnable`). | ||
* On top of that we have or own legacy version `akka.dispatch.Batchable`. | ||
*/ | ||
|
||
def isBatchable(runnable: Runnable): Boolean = runnable match { | ||
case b: akka.dispatch.Batchable => b.isBatchable | ||
case _: scala.concurrent.Batchable => true | ||
case _ => false | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure I fully understand what happened to the Scala internals as described in the comment above. What if this version of Akka is run in an application with Scala 2.13.3 dependency? Will it be caught by this
scala.concurrent.Batchable
case, or will this be a regression compared to previous OnCompleteRunnable?We might not care much about that and we can say that they should update to Scala 2.13.4. We already have another reason for that: #30018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OnCompleteRunnable
extendsBatchable
in all 2.13.x as far as I can see, so it should not cause a regression in older 2.13 releases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks