Use scala.concurrent.Batchable for Scala 2.13 #29986
Conversation
akka-ci
added
needs-attention
|
Test FAILed. |
1 similar comment
|
Test FAILed. |
akka-ci
added
validating
|
Test PASSed. |
|
PLS BUILD |
akka-ci
added
validating
|
Test PASSed. |
|
|
||
| def isBatchable(runnable: Runnable): Boolean = runnable match { | ||
| case b: akka.dispatch.Batchable => b.isBatchable | ||
| case _: scala.concurrent.Batchable => true |
There was a problem hiding this comment.
I'm sure I fully understand what happened to the Scala internals as described in the comment above. What if this version of Akka is run in an application with Scala 2.13.3 dependency? Will it be caught by this scala.concurrent.Batchable case, or will this be a regression compared to previous OnCompleteRunnable?
We might not care much about that and we can say that they should update to Scala 2.13.4. We already have another reason for that: #30018
There was a problem hiding this comment.
OnCompleteRunnable extends Batchable in all 2.13.x as far as I can see, so it should not cause a regression in older 2.13 releases.
|
Is there any plan for backport to akka 2.5.x? 👀 |
I don't think we're planning a backport, though if someone would contribute one I don't see a reason not to accept it. Be aware we're not really planning a new 2.5.x release either, though (but perhaps a snapshot would be sufficient if you need it sooner). |
References #29980
Manually tested with 2.12.11 and 2.13.3 however 2.13.4 requires quite a lot of changes (deprecated methods in
IterableOps, exhaustiveness check errors all over the place) and I didn't want to grow this PR so I let that be.With 2.13.4
impl.Promise.Transformationno longer extends the deprecatedOnCompleteRunnabledirectly but insteadscala.concurrent.Batchable. HoweverOnCompleteRunnableextendsBatchablesince 2.13.0 so matching againstBatchableshould be fine for all 2.13.x versions.