Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 22-23 compatiblity with reproducible builds #407

Merged
merged 20 commits into from
Apr 26, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Apr 25, 2024

No description provided.

@wendigo
Copy link
Contributor Author

wendigo commented Apr 25, 2024

@electrum PTAL. I've dropped opentelemetry updates from the previous PR. These are problematic right now in Trino (deprecations)

Which means that you can run build multiple times for a given commit and it will always produce the same, binary identical artifacts.
@wendigo
Copy link
Contributor Author

wendigo commented Apr 26, 2024

Verified reproducible build with Trino:

[INFO] Reproducible Build output summary: 574 files ok
[INFO] Reproducible Build output comparison saved to /Users/mateuszgajewski/Projects/src/github.com/trinodb/trino/testing/trino-test-jdbc-compatibility-old-server/target/trino-test-jdbc-compatibility-old-server-446-SNAPSHOT.buildcompare
[INFO] Aggregate buildcompare copied to /Users/mateuszgajewski/Projects/src/github.com/trinodb/trino/target/trino-root-446-SNAPSHOT.buildcompare
version=446-SNAPSHOT
ok=574
ko=0
ignored=0
okFiles="trino-root-446-SNAPSHOT.pom trino-testing-services-446-SNAPSHOT.pom trino-testing-services-446-SNAPSHOT.jar trino-testing-services-446-SNAPSHOT-tests.jar trino-testing-services-446-SNAPSHOT-sources.jar trino-testing-services-446-SNAPSHOT-test-sources.jar trino-spi-446-SNAPSHOT.pom trino-spi-446-SNAPSHOT.jar trino-spi-446-SNAPSHOT-tests.jar trino-spi-446-SNAPSHOT-sources.jar trino-spi-446-SNAPSHOT-test-sources.jar trino-client-446-SNAPSHOT.pom trino-client-446-SNAPSHOT.jar trino-client-446-SNAPSHOT-tests.jar trino-client-446-SNAPSHOT-sources.jar trino-client-446-SNAPSHOT-test-sources.jar trino-grammar-446-SNAPSHOT.pom trino-grammar-446-SNAPSHOT.jar trino-grammar-446-SNAPSHOT-tests.jar trino-grammar-446-SNAPSHOT-sources.jar trino-grammar-446-SNAPSHOT-test-sources.jar trino-cli-446-SNAPSHOT.pom trino-cli-446-SNAPSHOT.jar trino-cli-446-SNAPSHOT-tests.jar trino-cli-446-SNAPSHOT-sources.jar trino-cli-446-SNAPSHOT-test-sources.jar trino-cli-446-SNAPSHOT-executable.jar trino-cache-446-SNAPSHOT.pom trino-cache-446-SNAPSHOT.jar trino-cache-446-SNAPSHOT-tests.jar trino-cache-446-SNAPSHOT-sources.jar trino-cache-446-SNAPSHOT-test-sources.jar trino-matching-446-SNAPSHOT.pom trino-matching-446-SNAPSHOT.jar trino-matching-446-SNAPSHOT-tests.jar trino-matching-446-SNAPSHOT-sources.jar trino-matching-446-SNAPSHOT-test-sources.jar trino-plugin-toolkit-446-SNAPSHOT.pom trino-plugin-toolkit-446-SNAPSHOT.jar trino-plugin-toolkit-446-SNAPSHOT-tests.jar trino-plugin-toolkit-446-SNAPSHOT-sources.jar trino-plugin-toolkit-446-SNAPSHOT-test-sources.jar trino-array-446-SNAPSHOT.pom trino-array-446-SNAPSHOT.jar trino-array-446-SNAPSHOT-tests.jar trino-array-446-SNAPSHOT-sources.jar trino-array-446-SNAPSHOT-test-sources.jar trino-geospatial-toolkit-446-SNAPSHOT.pom trino-geospatial-toolkit-446-SNAPSHOT.jar trino-geospatial-toolkit-446-SNAPSHOT-tests.jar trino-geospatial-toolkit-446-SNAPSHOT-sources.jar trino-geospatial-toolkit-446-SNAPSHOT-test-sources.jar trino-memory-context-446-SNAPSHOT.pom trino-memory-context-446-SNAPSHOT.jar trino-memory-context-446-SNAPSHOT-tests.jar trino-memory-context-446-SNAPSHOT-sources.jar trino-memory-context-446-SNAPSHOT-test-sources.jar trino-parser-446-SNAPSHOT.pom trino-parser-446-SNAPSHOT.jar trino-parser-446-SNAPSHOT-tests.jar trino-parser-446-SNAPSHOT-sources.jar trino-parser-446-SNAPSHOT-test-sources.jar trino-testing-containers-446-SNAPSHOT.pom trino-testing-containers-446-SNAPSHOT.jar trino-testing-containers-446-SNAPSHOT-tests.jar trino-testing-containers-446-SNAPSHOT-sources.jar trino-testing-containers-446-SNAPSHOT-test-sources.jar trino-exchange-filesystem-446-SNAPSHOT.pom trino-exchange-filesystem-446-SNAPSHOT.zip trino-exchange-filesystem-446-SNAPSHOT.jar trino-exchange-filesystem-446-SNAPSHOT-tests.jar trino-exchange-filesystem-446-SNAPSHOT-sources.jar trino-exchange-filesystem-446-SNAPSHOT-test-sources.jar trino-tpch-446-SNAPSHOT.pom trino-tpch-446-SNAPSHOT.zip trino-tpch-446-SNAPSHOT.jar trino-tpch-446-SNAPSHOT-tests.jar trino-tpch-446-SNAPSHOT-sources.jar trino-tpch-446-SNAPSHOT-test-sources.jar trino-main-446-SNAPSHOT.pom trino-main-446-SNAPSHOT.jar trino-main-446-SNAPSHOT-tests.jar trino-main-446-SNAPSHOT-sources.jar trino-main-446-SNAPSHOT-test-sources.jar trino-testing-446-SNAPSHOT.pom trino-testing-446-SNAPSHOT.jar trino-testing-446-SNAPSHOT-tests.jar trino-testing-446-SNAPSHOT-sources.jar trino-testing-446-SNAPSHOT-test-sources.jar trino-blackhole-446-SNAPSHOT.pom trino-blackhole-446-SNAPSHOT.zip trino-blackhole-446-SNAPSHOT.jar trino-blackhole-446-SNAPSHOT-tests.jar trino-blackhole-446-SNAPSHOT-sources.jar trino-blackhole-446-SNAPSHOT-test-sources.jar trino-filesystem-446-SNAPSHOT.pom trino-filesystem-446-SNAPSHOT.jar trino-filesystem-446-SNAPSHOT-tests.jar trino-filesystem-446-SNAPSHOT-sources.jar trino-filesystem-446-SNAPSHOT-test-sources.jar trino-hdfs-446-SNAPSHOT.pom trino-hdfs-446-SNAPSHOT.jar trino-hdfs-446-SNAPSHOT-tests.jar trino-hdfs-446-SNAPSHOT-sources.jar trino-hdfs-446-SNAPSHOT-test-sources.jar trino-hdfs-446-SNAPSHOT.zip trino-filesystem-azure-446-SNAPSHOT.pom trino-filesystem-azure-446-SNAPSHOT.jar trino-filesystem-azure-446-SNAPSHOT-tests.jar trino-filesystem-azure-446-SNAPSHOT-sources.jar trino-filesystem-azure-446-SNAPSHOT-test-sources.jar trino-filesystem-cache-alluxio-446-SNAPSHOT.pom trino-filesystem-cache-alluxio-446-SNAPSHOT.jar trino-filesystem-cache-alluxio-446-SNAPSHOT-tests.jar trino-filesystem-cache-alluxio-446-SNAPSHOT-sources.jar trino-filesystem-cache-alluxio-446-SNAPSHOT-test-sources.jar trino-filesystem-gcs-446-SNAPSHOT.pom trino-filesystem-gcs-446-SNAPSHOT.jar trino-filesystem-gcs-446-SNAPSHOT-tests.jar trino-filesystem-gcs-446-SNAPSHOT-sources.jar trino-filesystem-gcs-446-SNAPSHOT-test-sources.jar trino-filesystem-s3-446-SNAPSHOT.pom trino-filesystem-s3-446-SNAPSHOT.jar trino-filesystem-s3-446-SNAPSHOT-tests.jar trino-filesystem-s3-446-SNAPSHOT-sources.jar trino-filesystem-s3-446-SNAPSHOT-test-sources.jar trino-filesystem-manager-446-SNAPSHOT.pom trino-filesystem-manager-446-SNAPSHOT.jar trino-filesystem-manager-446-SNAPSHOT-tests.jar trino-filesystem-manager-446-SNAPSHOT-sources.jar trino-filesystem-manager-446-SNAPSHOT-test-sources.jar trino-hive-formats-446-SNAPSHOT.pom trino-hive-formats-446-SNAPSHOT.jar trino-hive-formats-446-SNAPSHOT-tests.jar trino-hive-formats-446-SNAPSHOT-sources.jar trino-hive-formats-446-SNAPSHOT-test-sources.jar trino-orc-446-SNAPSHOT.pom trino-orc-446-SNAPSHOT.jar trino-orc-446-SNAPSHOT-tests.jar trino-orc-446-SNAPSHOT-sources.jar trino-orc-446-SNAPSHOT-test-sources.jar trino-parquet-446-SNAPSHOT.pom trino-parquet-446-SNAPSHOT.jar trino-parquet-446-SNAPSHOT-tests.jar trino-parquet-446-SNAPSHOT-sources.jar trino-parquet-446-SNAPSHOT-test-sources.jar trino-tpcds-446-SNAPSHOT.pom trino-tpcds-446-SNAPSHOT.zip trino-tpcds-446-SNAPSHOT.jar trino-tpcds-446-SNAPSHOT-tests.jar trino-tpcds-446-SNAPSHOT-sources.jar trino-tpcds-446-SNAPSHOT-test-sources.jar trino-hive-446-SNAPSHOT.pom trino-hive-446-SNAPSHOT.zip trino-hive-446-SNAPSHOT.jar trino-hive-446-SNAPSHOT-tests.jar trino-hive-446-SNAPSHOT-sources.jar trino-hive-446-SNAPSHOT-test-sources.jar trino-memory-446-SNAPSHOT.pom trino-memory-446-SNAPSHOT.zip trino-memory-446-SNAPSHOT.jar trino-memory-446-SNAPSHOT-tests.jar trino-memory-446-SNAPSHOT-sources.jar trino-memory-446-SNAPSHOT-test-sources.jar trino-password-authenticators-446-SNAPSHOT.pom trino-password-authenticators-446-SNAPSHOT.zip trino-password-authenticators-446-SNAPSHOT.jar trino-password-authenticators-446-SNAPSHOT-tests.jar trino-password-authenticators-446-SNAPSHOT-sources.jar trino-password-authenticators-446-SNAPSHOT-test-sources.jar trino-jdbc-446-SNAPSHOT.pom trino-jdbc-446-SNAPSHOT.jar trino-jdbc-446-SNAPSHOT-tests.jar trino-jdbc-446-SNAPSHOT-sources.jar trino-jdbc-446-SNAPSHOT-test-sources.jar trino-base-jdbc-446-SNAPSHOT.pom trino-base-jdbc-446-SNAPSHOT.jar trino-base-jdbc-446-SNAPSHOT-tests.jar trino-base-jdbc-446-SNAPSHOT-sources.jar trino-base-jdbc-446-SNAPSHOT-test-sources.jar trino-snowflake-446-SNAPSHOT.pom trino-snowflake-446-SNAPSHOT.zip trino-snowflake-446-SNAPSHOT.jar trino-snowflake-446-SNAPSHOT-tests.jar trino-snowflake-446-SNAPSHOT-sources.jar trino-snowflake-446-SNAPSHOT-test-sources.jar trino-accumulo-iterators-446-SNAPSHOT.pom trino-accumulo-iterators-446-SNAPSHOT.jar trino-accumulo-iterators-446-SNAPSHOT-tests.jar trino-accumulo-iterators-446-SNAPSHOT-sources.jar trino-accumulo-iterators-446-SNAPSHOT-test-sources.jar trino-accumulo-446-SNAPSHOT.pom trino-accumulo-446-SNAPSHOT.zip trino-accumulo-446-SNAPSHOT.jar trino-accumulo-446-SNAPSHOT-tests.jar trino-accumulo-446-SNAPSHOT-sources.jar trino-accumulo-446-SNAPSHOT-test-sources.jar trino-http-event-listener-446-SNAPSHOT.pom trino-http-event-listener-446-SNAPSHOT.zip trino-http-event-listener-446-SNAPSHOT.jar trino-http-event-listener-446-SNAPSHOT-tests.jar trino-http-event-listener-446-SNAPSHOT-sources.jar trino-http-event-listener-446-SNAPSHOT-test-sources.jar trino-phoenix5-patched-446-SNAPSHOT.pom trino-phoenix5-patched-446-SNAPSHOT.jar trino-phoenix5-patched-446-SNAPSHOT-tests.jar trino-phoenix5-patched-446-SNAPSHOT-sources.jar trino-phoenix5-patched-446-SNAPSHOT-test-sources.jar trino-phoenix5-446-SNAPSHOT.pom trino-phoenix5-446-SNAPSHOT.zip trino-phoenix5-446-SNAPSHOT.jar trino-phoenix5-446-SNAPSHOT-tests.jar trino-phoenix5-446-SNAPSHOT-sources.jar trino-phoenix5-446-SNAPSHOT-test-sources.jar trino-redshift-446-SNAPSHOT.pom trino-redshift-446-SNAPSHOT.zip trino-redshift-446-SNAPSHOT.jar trino-redshift-446-SNAPSHOT-tests.jar trino-redshift-446-SNAPSHOT-sources.jar trino-redshift-446-SNAPSHOT-test-sources.jar trino-oracle-446-SNAPSHOT.pom trino-oracle-446-SNAPSHOT.zip trino-oracle-446-SNAPSHOT.jar trino-oracle-446-SNAPSHOT-tests.jar trino-oracle-446-SNAPSHOT-sources.jar trino-oracle-446-SNAPSHOT-test-sources.jar trino-atop-446-SNAPSHOT.pom trino-atop-446-SNAPSHOT.zip trino-atop-446-SNAPSHOT.jar trino-atop-446-SNAPSHOT-tests.jar trino-atop-446-SNAPSHOT-sources.jar trino-atop-446-SNAPSHOT-test-sources.jar trino-session-property-managers-446-SNAPSHOT.pom trino-session-property-managers-446-SNAPSHOT.zip trino-session-property-managers-446-SNAPSHOT.jar trino-session-property-managers-446-SNAPSHOT-tests.jar trino-session-property-managers-446-SNAPSHOT-sources.jar trino-session-property-managers-446-SNAPSHOT-test-sources.jar trino-opa-446-SNAPSHOT.pom trino-opa-446-SNAPSHOT.zip trino-opa-446-SNAPSHOT.jar trino-opa-446-SNAPSHOT-tests.jar trino-opa-446-SNAPSHOT-sources.jar trino-opa-446-SNAPSHOT-test-sources.jar trino-raptor-legacy-446-SNAPSHOT.pom trino-raptor-legacy-446-SNAPSHOT.zip trino-raptor-legacy-446-SNAPSHOT.jar trino-raptor-legacy-446-SNAPSHOT-tests.jar trino-raptor-legacy-446-SNAPSHOT-sources.jar trino-raptor-legacy-446-SNAPSHOT-test-sources.jar trino-server-main-446-SNAPSHOT.pom trino-server-main-446-SNAPSHOT.jar trino-server-main-446-SNAPSHOT-tests.jar trino-server-main-446-SNAPSHOT-sources.jar trino-server-main-446-SNAPSHOT-test-sources.jar trino-record-decoder-446-SNAPSHOT.pom trino-record-decoder-446-SNAPSHOT.jar trino-record-decoder-446-SNAPSHOT-tests.jar trino-record-decoder-446-SNAPSHOT-sources.jar trino-record-decoder-446-SNAPSHOT-test-sources.jar trino-kinesis-446-SNAPSHOT.pom trino-kinesis-446-SNAPSHOT.zip trino-kinesis-446-SNAPSHOT.jar trino-kinesis-446-SNAPSHOT-tests.jar trino-kinesis-446-SNAPSHOT-sources.jar trino-kinesis-446-SNAPSHOT-test-sources.jar trino-mysql-446-SNAPSHOT.pom trino-mysql-446-SNAPSHOT.zip trino-mysql-446-SNAPSHOT.jar trino-mysql-446-SNAPSHOT-tests.jar trino-mysql-446-SNAPSHOT-sources.jar trino-mysql-446-SNAPSHOT-test-sources.jar trino-resource-group-managers-446-SNAPSHOT.pom trino-resource-group-managers-446-SNAPSHOT.zip trino-resource-group-managers-446-SNAPSHOT.jar trino-resource-group-managers-446-SNAPSHOT-tests.jar trino-resource-group-managers-446-SNAPSHOT-sources.jar trino-resource-group-managers-446-SNAPSHOT-test-sources.jar trino-hudi-446-SNAPSHOT.pom trino-hudi-446-SNAPSHOT.zip trino-hudi-446-SNAPSHOT.jar trino-hudi-446-SNAPSHOT-tests.jar trino-hudi-446-SNAPSHOT-sources.jar trino-hudi-446-SNAPSHOT-test-sources.jar trino-ignite-446-SNAPSHOT.pom trino-ignite-446-SNAPSHOT.zip trino-ignite-446-SNAPSHOT.jar trino-ignite-446-SNAPSHOT-tests.jar trino-ignite-446-SNAPSHOT-sources.jar trino-ignite-446-SNAPSHOT-test-sources.jar trino-ml-446-SNAPSHOT.pom trino-ml-446-SNAPSHOT.zip trino-ml-446-SNAPSHOT.jar trino-ml-446-SNAPSHOT-tests.jar trino-ml-446-SNAPSHOT-sources.jar trino-ml-446-SNAPSHOT-test-sources.jar trino-local-file-446-SNAPSHOT.pom trino-local-file-446-SNAPSHOT.zip trino-local-file-446-SNAPSHOT.jar trino-local-file-446-SNAPSHOT-tests.jar trino-local-file-446-SNAPSHOT-sources.jar trino-local-file-446-SNAPSHOT-test-sources.jar trino-testing-kafka-446-SNAPSHOT.pom trino-testing-kafka-446-SNAPSHOT.jar trino-testing-kafka-446-SNAPSHOT-tests.jar trino-testing-kafka-446-SNAPSHOT-sources.jar trino-testing-kafka-446-SNAPSHOT-test-sources.jar trino-pinot-446-SNAPSHOT.pom trino-pinot-446-SNAPSHOT.zip trino-pinot-446-SNAPSHOT.jar trino-pinot-446-SNAPSHOT-tests.jar trino-pinot-446-SNAPSHOT-sources.jar trino-pinot-446-SNAPSHOT-test-sources.jar trino-example-http-446-SNAPSHOT.pom trino-example-http-446-SNAPSHOT.zip trino-example-http-446-SNAPSHOT.jar trino-example-http-446-SNAPSHOT-tests.jar trino-example-http-446-SNAPSHOT-sources.jar trino-example-http-446-SNAPSHOT-test-sources.jar trino-google-sheets-446-SNAPSHOT.pom trino-google-sheets-446-SNAPSHOT.zip trino-google-sheets-446-SNAPSHOT.jar trino-google-sheets-446-SNAPSHOT-tests.jar trino-google-sheets-446-SNAPSHOT-sources.jar trino-google-sheets-446-SNAPSHOT-test-sources.jar trino-geospatial-446-SNAPSHOT.pom trino-geospatial-446-SNAPSHOT.zip trino-geospatial-446-SNAPSHOT.jar trino-geospatial-446-SNAPSHOT-tests.jar trino-geospatial-446-SNAPSHOT-sources.jar trino-geospatial-446-SNAPSHOT-test-sources.jar trino-mysql-event-listener-446-SNAPSHOT.pom trino-mysql-event-listener-446-SNAPSHOT.zip trino-mysql-event-listener-446-SNAPSHOT.jar trino-mysql-event-listener-446-SNAPSHOT-tests.jar trino-mysql-event-listener-446-SNAPSHOT-sources.jar trino-mysql-event-listener-446-SNAPSHOT-test-sources.jar trino-druid-446-SNAPSHOT.pom trino-druid-446-SNAPSHOT.zip trino-druid-446-SNAPSHOT.jar trino-druid-446-SNAPSHOT-tests.jar trino-druid-446-SNAPSHOT-sources.jar trino-druid-446-SNAPSHOT-test-sources.jar trino-kafka-446-SNAPSHOT.pom trino-kafka-446-SNAPSHOT.zip trino-kafka-446-SNAPSHOT.jar trino-kafka-446-SNAPSHOT-tests.jar trino-kafka-446-SNAPSHOT-sources.jar trino-kafka-446-SNAPSHOT-test-sources.jar trino-exchange-hdfs-446-SNAPSHOT.pom trino-exchange-hdfs-446-SNAPSHOT.zip trino-exchange-hdfs-446-SNAPSHOT.jar trino-exchange-hdfs-446-SNAPSHOT-tests.jar trino-exchange-hdfs-446-SNAPSHOT-sources.jar trino-exchange-hdfs-446-SNAPSHOT-test-sources.jar trino-jmx-446-SNAPSHOT.pom trino-jmx-446-SNAPSHOT.zip trino-jmx-446-SNAPSHOT.jar trino-jmx-446-SNAPSHOT-tests.jar trino-jmx-446-SNAPSHOT-sources.jar trino-jmx-446-SNAPSHOT-test-sources.jar trino-thrift-api-446-SNAPSHOT.pom trino-thrift-api-446-SNAPSHOT.jar trino-thrift-api-446-SNAPSHOT-tests.jar trino-thrift-api-446-SNAPSHOT-sources.jar trino-thrift-api-446-SNAPSHOT-test-sources.jar trino-thrift-testing-server-446-SNAPSHOT.pom trino-thrift-testing-server-446-SNAPSHOT.jar trino-thrift-testing-server-446-SNAPSHOT-tests.jar trino-thrift-testing-server-446-SNAPSHOT-sources.jar trino-thrift-testing-server-446-SNAPSHOT-test-sources.jar trino-thrift-testing-server-446-SNAPSHOT.tar.gz trino-thrift-testing-server-446-SNAPSHOT-readme.txt trino-thrift-446-SNAPSHOT.pom trino-thrift-446-SNAPSHOT.zip trino-thrift-446-SNAPSHOT.jar trino-thrift-446-SNAPSHOT-tests.jar trino-thrift-446-SNAPSHOT-sources.jar trino-thrift-446-SNAPSHOT-test-sources.jar trino-clickhouse-446-SNAPSHOT.pom trino-clickhouse-446-SNAPSHOT.zip trino-clickhouse-446-SNAPSHOT.jar trino-clickhouse-446-SNAPSHOT-tests.jar trino-clickhouse-446-SNAPSHOT-sources.jar trino-clickhouse-446-SNAPSHOT-test-sources.jar trino-opensearch-446-SNAPSHOT.pom trino-opensearch-446-SNAPSHOT.zip trino-opensearch-446-SNAPSHOT.jar trino-opensearch-446-SNAPSHOT-tests.jar trino-opensearch-446-SNAPSHOT-sources.jar trino-opensearch-446-SNAPSHOT-test-sources.jar trino-mongodb-446-SNAPSHOT.pom trino-mongodb-446-SNAPSHOT.zip trino-mongodb-446-SNAPSHOT.jar trino-mongodb-446-SNAPSHOT-tests.jar trino-mongodb-446-SNAPSHOT-sources.jar trino-mongodb-446-SNAPSHOT-test-sources.jar trino-iceberg-446-SNAPSHOT.pom trino-iceberg-446-SNAPSHOT.zip trino-iceberg-446-SNAPSHOT.jar trino-iceberg-446-SNAPSHOT-tests.jar trino-iceberg-446-SNAPSHOT-sources.jar trino-iceberg-446-SNAPSHOT-test-sources.jar trino-postgresql-446-SNAPSHOT.pom trino-postgresql-446-SNAPSHOT.zip trino-postgresql-446-SNAPSHOT.jar trino-postgresql-446-SNAPSHOT-tests.jar trino-postgresql-446-SNAPSHOT-sources.jar trino-postgresql-446-SNAPSHOT-test-sources.jar trino-singlestore-446-SNAPSHOT.pom trino-singlestore-446-SNAPSHOT.zip trino-singlestore-446-SNAPSHOT.jar trino-singlestore-446-SNAPSHOT-tests.jar trino-singlestore-446-SNAPSHOT-sources.jar trino-singlestore-446-SNAPSHOT-test-sources.jar trino-teradata-functions-446-SNAPSHOT.pom trino-teradata-functions-446-SNAPSHOT.zip trino-teradata-functions-446-SNAPSHOT.jar trino-teradata-functions-446-SNAPSHOT-tests.jar trino-teradata-functions-446-SNAPSHOT-sources.jar trino-teradata-functions-446-SNAPSHOT-test-sources.jar trino-elasticsearch-446-SNAPSHOT.pom trino-elasticsearch-446-SNAPSHOT.zip trino-elasticsearch-446-SNAPSHOT.jar trino-elasticsearch-446-SNAPSHOT-tests.jar trino-elasticsearch-446-SNAPSHOT-sources.jar trino-elasticsearch-446-SNAPSHOT-test-sources.jar trino-kudu-446-SNAPSHOT.pom trino-kudu-446-SNAPSHOT.zip trino-kudu-446-SNAPSHOT.jar trino-kudu-446-SNAPSHOT-tests.jar trino-kudu-446-SNAPSHOT-sources.jar trino-kudu-446-SNAPSHOT-test-sources.jar trino-bigquery-446-SNAPSHOT.pom trino-bigquery-446-SNAPSHOT.zip trino-bigquery-446-SNAPSHOT.jar trino-bigquery-446-SNAPSHOT-tests.jar trino-bigquery-446-SNAPSHOT-sources.jar trino-bigquery-446-SNAPSHOT-test-sources.jar trino-testing-resources-446-SNAPSHOT.pom trino-testing-resources-446-SNAPSHOT.jar trino-testing-resources-446-SNAPSHOT-tests.jar trino-testing-resources-446-SNAPSHOT-sources.jar trino-testing-resources-446-SNAPSHOT-test-sources.jar trino-delta-lake-446-SNAPSHOT.pom trino-delta-lake-446-SNAPSHOT.zip trino-delta-lake-446-SNAPSHOT.jar trino-delta-lake-446-SNAPSHOT-tests.jar trino-delta-lake-446-SNAPSHOT-sources.jar trino-delta-lake-446-SNAPSHOT-test-sources.jar trino-prometheus-446-SNAPSHOT.pom trino-prometheus-446-SNAPSHOT.zip trino-prometheus-446-SNAPSHOT.jar trino-prometheus-446-SNAPSHOT-tests.jar trino-prometheus-446-SNAPSHOT-sources.jar trino-prometheus-446-SNAPSHOT-test-sources.jar trino-cassandra-446-SNAPSHOT.pom trino-cassandra-446-SNAPSHOT.zip trino-cassandra-446-SNAPSHOT.jar trino-cassandra-446-SNAPSHOT-tests.jar trino-cassandra-446-SNAPSHOT-sources.jar trino-cassandra-446-SNAPSHOT-test-sources.jar trino-sqlserver-446-SNAPSHOT.pom trino-sqlserver-446-SNAPSHOT.zip trino-sqlserver-446-SNAPSHOT.jar trino-sqlserver-446-SNAPSHOT-tests.jar trino-sqlserver-446-SNAPSHOT-sources.jar trino-sqlserver-446-SNAPSHOT-test-sources.jar trino-mariadb-446-SNAPSHOT.pom trino-mariadb-446-SNAPSHOT.zip trino-mariadb-446-SNAPSHOT.jar trino-mariadb-446-SNAPSHOT-tests.jar trino-mariadb-446-SNAPSHOT-sources.jar trino-mariadb-446-SNAPSHOT-test-sources.jar trino-redis-446-SNAPSHOT.pom trino-redis-446-SNAPSHOT.zip trino-redis-446-SNAPSHOT.jar trino-redis-446-SNAPSHOT-tests.jar trino-redis-446-SNAPSHOT-sources.jar trino-redis-446-SNAPSHOT-test-sources.jar trino-server-446-SNAPSHOT.pom trino-server-446-SNAPSHOT.tar.gz trino-server-446-SNAPSHOT.jar trino-server-446-SNAPSHOT-tests.jar trino-server-446-SNAPSHOT-test-sources.jar trino-server-rpm-446-SNAPSHOT.pom trino-server-rpm-446-SNAPSHOT.rpm trino-server-rpm-446-SNAPSHOT-tests.jar trino-server-rpm-446-SNAPSHOT-sources.jar trino-server-rpm-446-SNAPSHOT-test-sources.jar trino-docs-446-SNAPSHOT.pom trino-docs-446-SNAPSHOT.zip trino-docs-446-SNAPSHOT-sources.jar trino-example-jdbc-446-SNAPSHOT.pom trino-example-jdbc-446-SNAPSHOT.zip trino-example-jdbc-446-SNAPSHOT.jar trino-example-jdbc-446-SNAPSHOT-tests.jar trino-example-jdbc-446-SNAPSHOT-sources.jar trino-example-jdbc-446-SNAPSHOT-test-sources.jar trino-proxy-446-SNAPSHOT.pom trino-proxy-446-SNAPSHOT.jar trino-proxy-446-SNAPSHOT-tests.jar trino-proxy-446-SNAPSHOT-sources.jar trino-proxy-446-SNAPSHOT-test-sources.jar trino-proxy-446-SNAPSHOT.tar.gz trino-proxy-446-SNAPSHOT-readme.txt trino-verifier-446-SNAPSHOT.pom trino-verifier-446-SNAPSHOT.jar trino-verifier-446-SNAPSHOT-tests.jar trino-verifier-446-SNAPSHOT-sources.jar trino-verifier-446-SNAPSHOT-test-sources.jar trino-verifier-446-SNAPSHOT-executable.jar trino-benchmark-queries-446-SNAPSHOT.pom trino-benchmark-queries-446-SNAPSHOT.jar trino-benchmark-queries-446-SNAPSHOT-tests.jar trino-benchmark-queries-446-SNAPSHOT-sources.jar trino-benchmark-queries-446-SNAPSHOT-test-sources.jar trino-benchto-benchmarks-446-SNAPSHOT.pom trino-benchto-benchmarks-446-SNAPSHOT.jar trino-benchto-benchmarks-446-SNAPSHOT-tests.jar trino-benchto-benchmarks-446-SNAPSHOT-sources.jar trino-benchto-benchmarks-446-SNAPSHOT-test-sources.jar trino-benchto-benchmarks-446-SNAPSHOT.tar.gz trino-benchto-benchmarks-446-SNAPSHOT.tar.bz2 trino-benchto-benchmarks-446-SNAPSHOT.zip trino-benchto-benchmarks-446-SNAPSHOT-executable.jar trino-tests-446-SNAPSHOT.pom trino-tests-446-SNAPSHOT.jar trino-tests-446-SNAPSHOT-tests.jar trino-tests-446-SNAPSHOT-sources.jar trino-tests-446-SNAPSHOT-test-sources.jar trino-faulttolerant-tests-446-SNAPSHOT.pom trino-faulttolerant-tests-446-SNAPSHOT.jar trino-faulttolerant-tests-446-SNAPSHOT-tests.jar trino-faulttolerant-tests-446-SNAPSHOT-sources.jar trino-faulttolerant-tests-446-SNAPSHOT-test-sources.jar trino-plugin-reader-446-SNAPSHOT.pom trino-plugin-reader-446-SNAPSHOT.jar trino-plugin-reader-446-SNAPSHOT-tests.jar trino-plugin-reader-446-SNAPSHOT-sources.jar trino-plugin-reader-446-SNAPSHOT-test-sources.jar trino-plugin-reader-446-SNAPSHOT-executable.jar trino-product-tests-groups-446-SNAPSHOT.pom trino-product-tests-groups-446-SNAPSHOT.jar trino-product-tests-groups-446-SNAPSHOT-tests.jar trino-product-tests-groups-446-SNAPSHOT-sources.jar trino-product-tests-groups-446-SNAPSHOT-test-sources.jar trino-product-tests-446-SNAPSHOT.pom trino-product-tests-446-SNAPSHOT.jar trino-product-tests-446-SNAPSHOT-tests.jar trino-product-tests-446-SNAPSHOT-sources.jar trino-product-tests-446-SNAPSHOT-test-sources.jar trino-product-tests-446-SNAPSHOT-executable.jar trino-product-tests-launcher-446-SNAPSHOT.pom trino-product-tests-launcher-446-SNAPSHOT.jar trino-product-tests-launcher-446-SNAPSHOT-tests.jar trino-product-tests-launcher-446-SNAPSHOT-sources.jar trino-product-tests-launcher-446-SNAPSHOT-test-sources.jar trino-product-tests-launcher-446-SNAPSHOT-executable.jar trino-server-dev-446-SNAPSHOT.pom trino-server-dev-446-SNAPSHOT.jar trino-server-dev-446-SNAPSHOT-tests.jar trino-server-dev-446-SNAPSHOT-sources.jar trino-server-dev-446-SNAPSHOT-test-sources.jar trino-test-jdbc-compatibility-old-driver-446-SNAPSHOT.pom trino-test-jdbc-compatibility-old-driver-446-SNAPSHOT.jar trino-test-jdbc-compatibility-old-driver-446-SNAPSHOT-tests.jar trino-test-jdbc-compatibility-old-driver-446-SNAPSHOT-sources.jar trino-test-jdbc-compatibility-old-driver-446-SNAPSHOT-test-sources.jar trino-test-jdbc-compatibility-old-server-446-SNAPSHOT.pom trino-test-jdbc-compatibility-old-server-446-SNAPSHOT.jar trino-test-jdbc-compatibility-old-server-446-SNAPSHOT-tests.jar trino-test-jdbc-compatibility-old-server-446-SNAPSHOT-sources.jar trino-test-jdbc-compatibility-old-server-446-SNAPSHOT-test-sources.jar"
koFiles=""
ignoredFiles=""
reference_java_version="22 (from MANIFEST.MF Build-Jdk-Spec)"
reference_os_name="Unix (from pom.properties newline)"

It works 🎉

@wendigo
Copy link
Contributor Author

wendigo commented Apr 26, 2024

Added a checkstyle rules configuration to allow for unnamed variables usage

@wendigo
Copy link
Contributor Author

wendigo commented Apr 26, 2024

cc @electrum PTAL

@electrum electrum merged commit c28f9b9 into airlift:master Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants