Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved JDK 22-23 compatibility, reproducible builds support #403

Closed
wants to merge 17 commits into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Mar 22, 2024

PMD 7.0.0 is finally compatible with JDK 21

@wendigo
Copy link
Contributor Author

wendigo commented Mar 22, 2024

cc @electrum

@wendigo wendigo changed the title Update PMD to 7.0.0 Update plugins and dependencies for better JDK 22 and 23 compatibility Apr 4, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Apr 8, 2024

@martint @electrum PTAL

@wendigo
Copy link
Contributor Author

wendigo commented Apr 11, 2024

Rebased, resolved conflicts and added maven-gpg-plugin

@wendigo wendigo force-pushed the serafin/pmd7 branch 2 times, most recently from 1ad0951 to 9ce76cf Compare April 13, 2024 12:46
@wendigo
Copy link
Contributor Author

wendigo commented Apr 13, 2024

@martint @electrum ptal

@wendigo
Copy link
Contributor Author

wendigo commented Apr 15, 2024

@martint @electrum gentle reminder

@wendigo wendigo changed the title Update plugins and dependencies for better JDK 22 and 23 compatibility Improved JDK 22-23 compatibility, reproducible builds support Apr 16, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Apr 18, 2024

Ping @martint @electrum

This makes it possible to override them in a child project without a need for an airbase release
which in turns makes it possible to test new versions or upgrade plugins directly in the child project.
@wendigo
Copy link
Contributor Author

wendigo commented Apr 22, 2024

@martint @electrum PTAL

@wendigo
Copy link
Contributor Author

wendigo commented Apr 23, 2024

Closing this PR because of the lack of interest from project maintainers.

@wendigo wendigo closed this Apr 23, 2024
@electrum electrum reopened this Apr 23, 2024
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for doing this.

airbase/pom.xml Outdated
@@ -1273,7 +1273,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>3.2.1</version>
<version>3.2.2</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 3.2.4

@@ -12,7 +12,8 @@ Airbase 155
- spotbugs-annotations 4.8.4 (from 4.8.3)
- jakarta.annotation-api 3.0.0 (from 2.1.1)
- opentelemetry 1.37.0 (from 1.36.0)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something weird happened with the diff here. No action needed, but I'm puzzled.

CHANGES.md Outdated
@@ -14,7 +14,8 @@ Airbase 155
- jakarta.annotation-api 3.0.0 (from 2.1.1)
- opentelemetry 1.37.0 (from 1.36.0)
- logback 1.5.6 (from 1.5.3)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here

airbase/pom.xml Show resolved Hide resolved
@wendigo wendigo closed this Apr 24, 2024
@wendigo wendigo deleted the serafin/pmd7 branch April 24, 2024 07:05
@wendigo
Copy link
Contributor Author

wendigo commented Apr 25, 2024

@electrum I'll post another PR where I start with the Move all versions to properties as a first commit

@wendigo
Copy link
Contributor Author

wendigo commented Apr 25, 2024

@electrum here's the new PR: #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants