Pin down multidict #6550
Merged
Pin down multidict #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
approved these changes
Jan 23, 2022
|
@Dreamsorcerer this probably needs a change note, though. |
psf-chronographer
bot
added
the
bot:chronographer:provided
22 tasks
|
Looks like it is already affecting some others. Maybe make a new 3.8 release tomorrow to minimise the impact? |
|
multidict 6.0.2 should fix problems. |
|
aiohttp 3.8.2 was just released and it restricts the multidict dependency to >=4.5,<6.0. Is this still intended? |
2 tasks
|
@jakob-keller Please see PR #6950 to re-bump it. |
1 task
webknjaz
added a commit
that referenced
this pull request
Sep 21, 2022
The `multidict` dependency used to be `multidict >=4.5, < 7.0` in `aiohttp` v3.8.1, but was pinned down to `multidict >=4.5, < 6.0` in `aiohttp` v3.8.2 (#6550) in an attempt to help avoid new errors. However, https://github.com/python/bedevere/ uses `multidict==6.0.2` so the requirements resolution fails with `aiohttp==3.8.2`: ```console ERROR: Cannot install -r requirements.txt (line 1) and multidict==6.0.2 because these package versions have conflicting dependencies. The conflict is caused by: The user requested multidict==6.0.2 aiohttp 3.8.2 depends on multidict<6.0 and >=4.5 To fix this you could try to: 1. loosen the range of package versions you've specified 2. remove package versions to allow pip attempt to solve the dependency conflict ``` https://github.com/hugovk/bedevere/actions/runs/3095794573/jobs/5010600772 This patch makes it possible to have `multidict` v6 installed in the same env as `aiohttp` v3.8.3, as with `aiohttp` v3.8.1. Partially related to closed #6600 and merged #6550. PR #6950 Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new errors coming in, it might be a good idea to pin this down in the 3.8 release.