Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fix MultiDict typing with multidict-6.0.0 (#64733) #64792

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jan 23, 2022

Proposed change

This will revert #64733, since it has been fixed upstream with 6.0.1
https://github.com/aio-libs/multidict/releases/tag/v6.0.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@mib1185 mib1185 requested a review from a team as a code owner January 23, 2022 21:00
@probot-home-assistant probot-home-assistant bot added bugfix core small-pr PRs with less than 30 lines. labels Jan 23, 2022
@project-bot project-bot bot added this to Needs review in Dev Jan 23, 2022
@mib1185 mib1185 requested a review from bdraco January 23, 2022 21:01
Dev automation moved this from Needs review to Reviewer approved Jan 23, 2022
@mib1185
Copy link
Contributor Author

mib1185 commented Jan 23, 2022

these errors are also related to multidict - but this time they occur only from 6.0.1, but not with 5.2.0 or 6.0.0 馃槙

Error: homeassistant/components/http/ban.py:120: error: No overload variant of "get" of "Mapping" matches argument type "str"  [call-overload]
homeassistant/components/http/ban.py:120: note: Possible overload variants:
homeassistant/components/http/ban.py:120: note:     def get(self, key: istr) -> Optional[str]
homeassistant/components/http/ban.py:120: note:     def [_T] get(self, istr, Union[str, _T]) -> Union[str, _T]
Error: homeassistant/helpers/config_entry_oauth2_flow.py:135: error: No overload variant of "get" of "Mapping" matches argument type "str"  [call-overload]
homeassistant/helpers/config_entry_oauth2_flow.py:135: note: Possible overload variants:
homeassistant/helpers/config_entry_oauth2_flow.py:135: note:     def get(self, key: istr) -> Optional[str]
homeassistant/helpers/config_entry_oauth2_flow.py:135: note:     def [_T] get(self, istr, Union[str, _T]) -> Union[str, _T]
Error: homeassistant/components/buienradar/camera.py:134: error: No overload variant of "get" of "Mapping" matches argument type "str"  [call-overload]
homeassistant/components/buienradar/camera.py:134: note: Possible overload variants:
homeassistant/components/buienradar/camera.py:134: note:     def get(self, key: istr) -> Optional[str]
homeassistant/components/buienradar/camera.py:134: note:     def [_T] get(self, istr, Union[str, _T]) -> Union[str, _T]
Found 3 errors in 3 files (checked 4578 source files)

@mib1185
Copy link
Contributor Author

mib1185 commented Jan 23, 2022

in aiohttp multidict has been pined down <6.0.0 since they observe also many issue with new version
aio-libs/aiohttp#6550

@mib1185 mib1185 force-pushed the core/revert-Fix-MultiDict-typing-with-multidict-6.0.0 branch from 2b6e10b to 5ca2fb4 Compare January 23, 2022 21:40
@mib1185 mib1185 merged commit 2f0059f into home-assistant:dev Jan 23, 2022
Dev automation moved this from Reviewer approved to Done Jan 23, 2022
@mib1185 mib1185 deleted the core/revert-Fix-MultiDict-typing-with-multidict-6.0.0 branch January 23, 2022 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed core small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants