Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5611/9a1c8623 backport][3.8] coroutine is allowed to return web.AppRunner #6150

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 28, 2021

This is a backport of PR #5611 as merged into master (9a1c862).

What do these changes do?

These changes allow the configuration of web.AppRunner object inside application code. This makes possible to use custom configs of Aiohttp server (like 'max_line_size' parameters setup) in pair with Gunicorn.

Are there changes in behavior for the user?

Extends configuration flexibility

Related issue number

#2988 (reference)

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
(cherry picked from commit 9a1c862)
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #6150 (9a1c862) into 3.8 (66e281f) will decrease coverage by 4.23%.
The diff coverage is 90.51%.

❗ Current head 9a1c862 differs from pull request most recent head fddc882. Consider uploading reports for the commit fddc882 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #6150      +/-   ##
==========================================
- Coverage   97.52%   93.29%   -4.24%     
==========================================
  Files          44      102      +58     
  Lines        8865    30218   +21353     
  Branches     1429     2710    +1281     
==========================================
+ Hits         8646    28192   +19546     
- Misses        103     1849    +1746     
- Partials      116      177      +61     
Flag Coverage Δ
unit 93.22% <90.31%> (-4.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 97.93% <ø> (-2.07%) ⬇️
aiohttp/web_log.py 100.00% <ø> (ø)
aiohttp/web_middlewares.py 100.00% <ø> (ø)
aiohttp/web_protocol.py 86.41% <ø> (-4.20%) ⬇️
aiohttp/web_request.py 95.91% <ø> (-1.65%) ⬇️
aiohttp/web_response.py 98.41% <ø> (+0.14%) ⬆️
aiohttp/web_routedef.py 98.11% <ø> (+0.01%) ⬆️
aiohttp/web_runner.py 92.34% <ø> (-5.29%) ⬇️
aiohttp/web_server.py 94.28% <ø> (-5.72%) ⬇️
aiohttp/web_urldispatcher.py 97.54% <ø> (-0.06%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8efd32...fddc882. Read the comment docs.

@asvetlov asvetlov merged commit 9e8df1e into 3.8 Oct 28, 2021
@asvetlov asvetlov deleted the patchback/backports/3.8/9a1c86237eaf2b8ac7ebc5d72e577ab1aaf5292a/pr-5611 branch October 28, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants