coroutine is allowed to return web.AppRunner #5611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes allow the configuration of web.AppRunner object inside application code. This makes possible to use custom configs of Aiohttp server (like 'max_line_size' parameters setup) in pair with Gunicorn. Associated issue: aio-libs#2988 (reference)
psf-chronographer
bot
added
the
bot:chronographer:provided
Depreceted style of 80 symbols width limit was needed. New style of 120 symbols for wide displays is much better
Codecov Report
@@ Coverage Diff @@
## master #5611 +/- ##
==========================================
- Coverage 93.31% 93.29% -0.02%
==========================================
Files 102 102
Lines 30212 30218 +6
Branches 2708 2710 +2
==========================================
Hits 28192 28192
- Misses 1843 1849 +6
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Oct 28, 2021
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6150 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com> (cherry picked from commit 9a1c862)
5 tasks
aio-libs-github-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
💚 Backport successfulThe PR was backported to the following branches:
|
asvetlov
added a commit
that referenced
this pull request
Oct 28, 2021
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com> Co-authored-by: loven-doo <1429305+loven-doo@users.noreply.github.com> Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
asvetlov
pushed a commit
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These changes allow the configuration of web.AppRunner object inside application code. This makes possible to use custom configs of Aiohttp server (like 'max_line_size' parameters setup) in pair with Gunicorn.
Are there changes in behavior for the user?
Extends configuration flexibility
Related issue number
#2988 (reference)
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.