Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie jar delete specific cookie #5249

Merged
merged 8 commits into from Nov 23, 2020
Merged

Conversation

derlih
Copy link
Contributor

@derlih derlih commented Nov 16, 2020

What do these changes do?

Add a predicate to AbstractCookieJar.clear
Add AbstractCookieJar.clear_domain method

Are there changes in behavior for the user?

Yes

Related issue number

Fixes #4942

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #5249 (f628c70) into master (e18c47f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5249      +/-   ##
==========================================
- Coverage   97.54%   97.53%   -0.01%     
==========================================
  Files          43       43              
  Lines        8794     8818      +24     
  Branches     1413     1418       +5     
==========================================
+ Hits         8578     8601      +23     
- Misses        101      102       +1     
  Partials      115      115              
Flag Coverage Δ
unit 97.36% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/abc.py 100.00% <100.00%> (ø)
aiohttp/cookiejar.py 98.77% <100.00%> (-0.40%) ⬇️
aiohttp/client_exceptions.py 98.33% <0.00%> (-1.67%) ⬇️
aiohttp/connector.py 96.80% <0.00%> (ø)
aiohttp/test_utils.py 99.68% <0.00%> (ø)
aiohttp/web_protocol.py 92.28% <0.00%> (ø)
aiohttp/http_websocket.py 98.65% <0.00%> (+<0.01%) ⬆️
aiohttp/client_reqrep.py 97.39% <0.00%> (+0.01%) ⬆️
aiohttp/http_parser.py 97.14% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18c47f...f628c70. Read the comment docs.

docs/abc.rst Outdated Show resolved Hide resolved
docs/abc.rst Outdated Show resolved Hide resolved
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asvetlov asvetlov merged commit e65f1a9 into aio-libs:master Nov 23, 2020
@aio-libs-github-bot
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

asvetlov added a commit that referenced this pull request Nov 23, 2020
* api

* some impl

* clear_domain and tests

* Add changes file

* update docs

* Update 4942.feature

* Update docs/abc.rst

* Update docs/abc.rst

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>.
(cherry picked from commit e65f1a9)

Co-authored-by: Dmitry Erlikh <derlih@gmail.com>
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
* api

* some impl

* clear_domain and tests

* Add changes file

* update docs

* Update 4942.feature

* Update docs/abc.rst

* Update docs/abc.rst

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
* api

* some impl

* clear_domain and tests

* Add changes file

* update docs

* Update 4942.feature

* Update docs/abc.rst

* Update docs/abc.rst

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method to delete a specific set of cookies
2 participants