New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie jar delete specific cookie #5249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5249 +/- ##
==========================================
- Coverage 97.54% 97.53% -0.01%
==========================================
Files 43 43
Lines 8794 8818 +24
Branches 1413 1418 +5
==========================================
+ Hits 8578 8601 +23
- Misses 101 102 +1
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
* api * some impl * clear_domain and tests * Add changes file * update docs * Update 4942.feature * Update docs/abc.rst * Update docs/abc.rst Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>. (cherry picked from commit e65f1a9) Co-authored-by: Dmitry Erlikh <derlih@gmail.com>
* api * some impl * clear_domain and tests * Add changes file * update docs * Update 4942.feature * Update docs/abc.rst * Update docs/abc.rst Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
* api * some impl * clear_domain and tests * Add changes file * update docs * Update 4942.feature * Update docs/abc.rst * Update docs/abc.rst Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
What do these changes do?
Add a predicate to AbstractCookieJar.clear
Add AbstractCookieJar.clear_domain method
Are there changes in behavior for the user?
Yes
Related issue number
Fixes #4942
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.