Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] Cookie jar delete specific cookie #5280

Merged
merged 2 commits into from
Nov 23, 2020
Merged

[3.8] Cookie jar delete specific cookie #5280

merged 2 commits into from
Nov 23, 2020

Conversation

asvetlov
Copy link
Member

Backport of #5249

derlih and others added 2 commits November 23, 2020 19:10
@derlih @asvetlov
Fix
6f7cd77
@asvetlov @derlih
[3.8] Cookie jar delete specific cookie (#5249)
4ee3098 
* api

* some impl

* clear_domain and tests

* Add changes file

* update docs

* Update 4942.feature

* Update docs/abc.rst

* Update docs/abc.rst

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>.
(cherry picked from commit e65f1a9)

Co-authored-by: Dmitry Erlikh <derlih@gmail.com>
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 23, 2020
@codecov
Copy link

codecov bot commented Nov 23, 2020 •
edited

Codecov Report

Merging #5280 (4ee3098) into 3.8 (d88aa16) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #5280      +/-   ##
==========================================
- Coverage   97.53%   97.52%   -0.01%     
==========================================
  Files          44       44              
  Lines        8858     8865       +7     
  Branches     1426     1429       +3     
==========================================
+ Hits         8640     8646       +6     
- Misses        102      103       +1     
  Partials      116      116
Flag Coverage Δ
unit 97.34% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/abc.py 100.00% <100.00%> (ø)
aiohttp/cookiejar.py 98.77% <100.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88aa16...4ee3098. Read the comment docs.

@asvetlov asvetlov closed this Nov 23, 2020
@asvetlov asvetlov reopened this Nov 23, 2020
@asvetlov asvetlov merged commit 66e281f into 3.8 Nov 23, 2020
@asvetlov asvetlov deleted the backport-e65f1a9-3.8 branch November 23, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asvetlov @derlih