Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Bugfix catch connection errors #1324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ap1erce
Copy link

@ap1erce ap1erce commented Mar 19, 2022

What do these changes do?

Catch built-in python ConnectionErrors when acquiring a new connection from the pool

Are there changes in behavior for the user?

N/A

Related issue number

1323

Checklist

  • [X ] I think the code is well written
  • Unit tests for the changes exist
  • [X ] Documentation reflects the changes
  • [X ] If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • [X ] Add a new news fragment into the CHANGES/ folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example:
      Fix issue with non-ascii contents in doctest text files.

@ap1erce
Copy link
Author

ap1erce commented Mar 19, 2022

I believe this also solves #1313 and #1314 while keeping in-line with redis-py

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant