Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

ConnectionResetError / Catch OSError in get_connection #1323

Open
1 task done
ap1erce opened this issue Mar 19, 2022 · 3 comments
Open
1 task done

ConnectionResetError / Catch OSError in get_connection #1323

ap1erce opened this issue Mar 19, 2022 · 3 comments
Labels

Comments

@ap1erce
Copy link

ap1erce commented Mar 19, 2022

Describe the bug

aioredis.exceptions.ConnectionError is a custom exception that does not catch built-in python ConnectionErrors. As a result, Connection.get_connection may return broken/invalid connections.

To Reproduce

See redis/redis-py#1772

Expected behavior

Connection.get_connection should catch OSError in addition to aioredis.exceptions.ConnectionError

Logs/tracebacks

N/A

Python Version

$ python --version
v3.6.9

aioredis Version

$ python -m pip show aioredis

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
@ap1erce ap1erce added the bug label Mar 19, 2022
@ap1erce
Copy link
Author

ap1erce commented Mar 19, 2022

See #1324

I believe this also solves #1313 and #1314 while keeping in-line with redis-py

@jonathansp
Copy link

updates on this?

@ap1erce
Copy link
Author

ap1erce commented Jul 7, 2022

@jonathansp aioredis has been merged into redis-py and is now deprecated. The async redis-py module has this fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants