Redis update 2021-10-08 #1156

Andrew-Chen-Wang · 2021-10-08T15:12:28Z

What do these changes do?

Updates aioredis to redis at commit redis/redis-py@9419f1d

This does NOT include "Add retry mechanism with backoff (#1494)"

There may be additional updates to redis-py that merge my PRs there, but they should already be included here.

Are there changes in behavior for the user?

Yes, several new commands

Related issue number

Fixes #1145 #1136 #1130 #1205

Several

Checklist

I think the code is well written
Unit tests for the changes exist
Documentation reflects the changes
If you provide code modification, please add yourself to CONTRIBUTORS.txt
- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
Add a new news fragment into the CHANGES/ folder
- name it <issue_id>.<type> (e.g. 588.bugfix)
- if you don't have an issue_id change it to the pr id after creating the PR
- ensure type is one of the following:
  - .feature: Signifying a new feature.
  - .bugfix: Signifying a bug fix.
  - .doc: Signifying a documentation improvement.
  - .removal: Signifying a deprecation or removal of public API.
  - .misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example:
  Fix issue with non-ascii contents in doctest text files.

changing unit tests to account for defaults in redis flags redis/redis-py#1499 * This does not include the changes in tests/test_pubsub.py because we do not implement threading. Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add support for COPY command new in Redis 6.2 (redis/redis-py#1492) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

getex (redis/redis-py#1515) * Removed small doc saying all time parameters can be datetime.timedelta. This is not needed with typing and can also be confusing with PXAT and EXAT Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

client_list (redis/redis-py#1517) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

hrandfield (redis/redis-py#1513) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

NOMKSTREAM support for XADD (redis/redis-py#1507) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

support for client unpause (redis/redis-py#1512) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Implements CLIENT KILL laddr filter (redis/redis-py#1506) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

getdel (redis/redis-py#1514) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

zrandmember (redis/redis-py#1519) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

LT and GT support for ZADD (redis/redis-py#1509) * The flags seem to be boolean, but I'm not sure why the test case has integers for test_zadd_gt_lt. Either way, I've set the annotation to be boolean only. Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

zrangestore (redis/redis-py#1521) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

zdiff and zdiffstore (redis/redis-py#1518) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

ensuring we adhere to exlusive options for getex (redis/redis-py#1531) * Also fixed type annotation for name to be KeyT Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Word was repeated in documentation (redis/redis-py#1532) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

zinter (redis/redis-py#1520) * Made some adjustments to typing in _zaggregate Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

exclusive gt and lt in zadd (redis/redis-py#1533) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

fix getex flaky tests (redis/redis-py#1537) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Updating base testing docker to redis 6.2.5 (redis/redis-py#1536) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add a count parameter to lpop/rpop for redis >= 6.2.0 (redis/redis-py#1487) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

add idle to xpending (redis/redis-py#1523) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

@Andrew-Chen-Wang

xautoclaim (redis/redis-py#1529) * Note: @Andrew-Chen-Wang wanted to change nonnegative to non-negative, but either is acceptable: https://math.stackexchange.com/questions/3342643/nonnegative-vs-non-negative * Fixed xpending_range type annotation * Fixed grammar in xautoclaim Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Fix some typos. (redis/redis-py#1496) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Added GET argument to SET command (redis/redis-py#1412) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

implementing the LMOVE and BLMOVE commands (redis/redis-py#1504) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

MINID and LIMIT support for xtrim (redis/redis-py#1508) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Adding support for CLIENT LIST with ID (redis/redis-py#1505) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Zunion (redis/redis-py#1512) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Migrating commands to a mixin (redis/redis-py#1534) * Fixes #1136 * Added typing.py to store type annotations Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Use Version instead of StrictVersion since distutils is deprecated. (redis/redis-py#1552) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

m-novikov · 2021-11-22T20:16:48Z

pytest.ini

@@ -0,0 +1,3 @@
+[pytest]
+markers =
+    redismod: run only the redis module tests


I'd say this should be deselected by default, also I'd like to point out there is redis/redis-py#1715 in the parent repo.

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Andrew-Chen-Wang · 2022-01-03T03:59:01Z

@seandstewart Further PRs will still be using the old layout. I think we should merge this now before further patches and stuff come and this'll be forever delayed. Additionally, I don't think it's necessary to bump to 3.0 yet; I think we should bump version to 2.1.0. The number of changes and additions here isn't breaking anything. We should create a new PR for redis-py 4.0.2+ rather than use this one.

lgtm-com · 2022-01-03T04:05:33Z

This pull request introduces 6 alerts and fixes 4 when merging 817e9b0 into 56d6b32 - view on LGTM.com

new alerts:

2 for Conflicting attributes in base classes
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for Modification of parameter with default
1 for Module is imported with 'import' and 'import from'

fixed alerts:

1 for Multiple calls to `__init__` during object initialization
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for First argument to super() is not enclosing class

lgtm-com · 2022-01-12T01:57:05Z

This pull request introduces 6 alerts and fixes 4 when merging 505878a into 56d6b32 - view on LGTM.com

new alerts:

2 for Conflicting attributes in base classes
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for Modification of parameter with default
1 for Module is imported with 'import' and 'import from'

fixed alerts:

1 for Multiple calls to `__init__` during object initialization
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for First argument to super() is not enclosing class

lgtm-com · 2022-01-12T03:31:10Z

This pull request introduces 6 alerts and fixes 4 when merging 61612b1 into 56d6b32 - view on LGTM.com

new alerts:

2 for Conflicting attributes in base classes
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for Modification of parameter with default
1 for Module is imported with 'import' and 'import from'

fixed alerts:

1 for Multiple calls to `__init__` during object initialization
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for First argument to super() is not enclosing class

lgtm-com · 2022-01-12T03:53:15Z

This pull request introduces 6 alerts and fixes 4 when merging cb93ef4 into 56d6b32 - view on LGTM.com

new alerts:

2 for Conflicting attributes in base classes
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for Modification of parameter with default
1 for Module is imported with 'import' and 'import from'

fixed alerts:

1 for Multiple calls to `__init__` during object initialization
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for First argument to super() is not enclosing class

Urahara · 2022-02-04T00:06:21Z

We have a ETA when this will hit production?

Andrew-Chen-Wang · 2022-02-10T18:09:42Z

This will be included in redis-py's asyncio module. Can't get an ETA. Hopefully end of month.

Andrew-Chen-Wang added 30 commits October 4, 2021 15:29

Add redis/redis-py@cb97b9b

d37bb21

changing unit tests to account for defaults in redis flags redis/redis-py#1499 * This does not include the changes in tests/test_pubsub.py because we do not implement threading. Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@9ce7bb2

68a7de7

Add support for COPY command new in Redis 6.2 (redis/redis-py#1492) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@3c244af

a389184

getex (redis/redis-py#1515) * Removed small doc saying all time parameters can be datetime.timedelta. This is not needed with typing and can also be confusing with PXAT and EXAT Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@ad4779e

b7ede71

client_list (redis/redis-py#1517) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@627db54

e41b41c

hrandfield (redis/redis-py#1513) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@57cf7ff

0c3d2ba

NOMKSTREAM support for XADD (redis/redis-py#1507) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@88e5bd8

1829beb

support for client unpause (redis/redis-py#1512) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@b021f5a

d1bed29

Implements CLIENT KILL laddr filter (redis/redis-py#1506) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@01b96db

5cb5a3b

getdel (redis/redis-py#1514) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@e706445

0baf344

zrandmember (redis/redis-py#1519) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@53fe4d3

10f2435

zrangestore (redis/redis-py#1521) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@fc69bd6

eb6c66d

zdiff and zdiffstore (redis/redis-py#1518) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@be26730

d323846

ensuring we adhere to exlusive options for getex (redis/redis-py#1531) * Also fixed type annotation for name to be KeyT Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@e9c2e45

dde66f3

Word was repeated in documentation (redis/redis-py#1532) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@6f4ee2d

57a21bb

zinter (redis/redis-py#1520) * Made some adjustments to typing in _zaggregate Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@3c0e116

82e74e6

exclusive gt and lt in zadd (redis/redis-py#1533) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@ec89d30

2773c34

fix getex flaky tests (redis/redis-py#1537) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@5240d60

293d90f

Updating base testing docker to redis 6.2.5 (redis/redis-py#1536) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@238f69e

961da8c

Add a count parameter to lpop/rpop for redis >= 6.2.0 (redis/redis-py#1487) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@9c60670

af9f1c7

add idle to xpending (redis/redis-py#1523) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@8c4fc80

c5e63df

Fix some typos. (redis/redis-py#1496) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@2789f08

86473fd

Added GET argument to SET command (redis/redis-py#1412) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@37e7c09

05eef1f

implementing the LMOVE and BLMOVE commands (redis/redis-py#1504) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@e498182

30e2082

MINID and LIMIT support for xtrim (redis/redis-py#1508) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@161774b

3bef54d

Adding support for CLIENT LIST with ID (redis/redis-py#1505) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@8c82e42

b6c8416

Zunion (redis/redis-py#1512) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@8ea26c4

94e2b06

Migrating commands to a mixin (redis/redis-py#1534) * Fixes #1136 * Added typing.py to store type annotations Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@8ea26c4

d11ecd9

Use Version instead of StrictVersion since distutils is deprecated. (redis/redis-py#1552) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

m-novikov reviewed Nov 22, 2021

View reviewed changes

Andrew-Chen-Wang mentioned this pull request Nov 30, 2021

Necessary issues to resolve #1225

Open

8 tasks

This was referenced Dec 10, 2021

GETDEL command #1233

Open

redistimeseries integration? #1238

Open

Andrew-Chen-Wang mentioned this pull request Dec 24, 2021

ConnectionResetError: [Errno 104] Connection reset by peer #778

Open

Merge branch 'master' into redis-update

4c97fd7

Andrew-Chen-Wang mentioned this pull request Jan 3, 2022

Redis update #1262

Closed

5 tasks

Update test_json tests and revert some of my changes

817e9b0

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Andrew-Chen-Wang requested a review from seandstewart January 3, 2022 03:58

This was referenced Jan 3, 2022

Can't pass multiple arguments to hset(..., mappint={...}) #1261

Closed

More broad aioredis version requirement django/channels_redis#268

Closed

await fail in call_with_retry

505878a

Update test_retry.py

61612b1

This was linked to issues Jan 12, 2022

ConnectionResetError: [Errno 104] Connection reset by peer #778

Open

GETDEL command #1233

Open

redistimeseries integration? #1238

Open

Andrew-Chen-Wang mentioned this pull request Jan 12, 2022

Some arguments missing in API comparing to redis-py and Redis commands #1260

Open

1 task

Andrew-Chen-Wang linked an issue Jan 12, 2022 that may be closed by this pull request

Some arguments missing in API comparing to redis-py and Redis commands #1260

Open

1 task

This was referenced Jan 12, 2022

Use covariant type Mapping instead of invariant type Dict in arguments and let's wait for mypy upstream issue about nested Union #1182

Open

[2.0] xread() halts when the connection is lost. #1174

Open

Andrew-Chen-Wang linked an issue Jan 12, 2022 that may be closed by this pull request

[2.0] xread() halts when the connection is lost. #1174

Open

1 task

Hotfix add redis/redis-py#1832

cb93ef4

pseusys mentioned this pull request Feb 9, 2023

Migration to async DB drivers deeppavlov/dialog_flow_framework#60

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redis update 2021-10-08 #1156

Redis update 2021-10-08 #1156

Andrew-Chen-Wang commented Oct 8, 2021 •

edited

m-novikov Nov 22, 2021

Andrew-Chen-Wang commented Jan 3, 2022 •

edited

lgtm-com bot commented Jan 3, 2022

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 12, 2022

Urahara commented Feb 4, 2022

Andrew-Chen-Wang commented Feb 10, 2022 •

edited

Redis update 2021-10-08 #1156

Are you sure you want to change the base?

Redis update 2021-10-08 #1156

Conversation

Andrew-Chen-Wang commented Oct 8, 2021 • edited

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

m-novikov Nov 22, 2021

Choose a reason for hiding this comment

Andrew-Chen-Wang commented Jan 3, 2022 • edited

lgtm-com bot commented Jan 3, 2022

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 12, 2022

Urahara commented Feb 4, 2022

Andrew-Chen-Wang commented Feb 10, 2022 • edited

Andrew-Chen-Wang commented Oct 8, 2021 •

edited

Andrew-Chen-Wang commented Jan 3, 2022 •

edited

Andrew-Chen-Wang commented Feb 10, 2022 •

edited