Redis update #1262

Andrew-Chen-Wang · 2022-01-03T02:03:39Z

What do these changes do?

Updated 2021-10-08 from #1156 to be up to date with aioredis master. This is made for immediate merge rather than waiting. I've kept the other PR untouched for reference

Are there changes in behavior for the user?

No

Related issue number

#1156

Checklist

I think the code is well written
Unit tests for the changes exist
Documentation reflects the changes
If you provide code modification, please add yourself to CONTRIBUTORS.txt
- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
Add a new news fragment into the CHANGES/ folder
- name it <issue_id>.<type> (e.g. 588.bugfix)
- if you don't have an issue_id change it to the pr id after creating the PR
- ensure type is one of the following:
  - .feature: Signifying a new feature.
  - .bugfix: Signifying a bug fix.
  - .doc: Signifying a documentation improvement.
  - .removal: Signifying a deprecation or removal of public API.
  - .misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example:
  Fix issue with non-ascii contents in doctest text files.

View rendered README.md

changing unit tests to account for defaults in redis flags redis/redis-py#1499 * This does not include the changes in tests/test_pubsub.py because we do not implement threading. Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add support for COPY command new in Redis 6.2 (redis/redis-py#1492) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

getex (redis/redis-py#1515) * Removed small doc saying all time parameters can be datetime.timedelta. This is not needed with typing and can also be confusing with PXAT and EXAT Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

client_list (redis/redis-py#1517) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

hrandfield (redis/redis-py#1513) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

NOMKSTREAM support for XADD (redis/redis-py#1507) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

support for client unpause (redis/redis-py#1512) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Implements CLIENT KILL laddr filter (redis/redis-py#1506) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

getdel (redis/redis-py#1514) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

zrandmember (redis/redis-py#1519) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

LT and GT support for ZADD (redis/redis-py#1509) * The flags seem to be boolean, but I'm not sure why the test case has integers for test_zadd_gt_lt. Either way, I've set the annotation to be boolean only. Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

zrangestore (redis/redis-py#1521) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

zdiff and zdiffstore (redis/redis-py#1518) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

ensuring we adhere to exlusive options for getex (redis/redis-py#1531) * Also fixed type annotation for name to be KeyT Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Word was repeated in documentation (redis/redis-py#1532) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

zinter (redis/redis-py#1520) * Made some adjustments to typing in _zaggregate Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

exclusive gt and lt in zadd (redis/redis-py#1533) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

fix getex flaky tests (redis/redis-py#1537) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Updating base testing docker to redis 6.2.5 (redis/redis-py#1536) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add a count parameter to lpop/rpop for redis >= 6.2.0 (redis/redis-py#1487) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

add idle to xpending (redis/redis-py#1523) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

@Andrew-Chen-Wang

xautoclaim (redis/redis-py#1529) * Note: @Andrew-Chen-Wang wanted to change nonnegative to non-negative, but either is acceptable: https://math.stackexchange.com/questions/3342643/nonnegative-vs-non-negative * Fixed xpending_range type annotation * Fixed grammar in xautoclaim Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Fix some typos. (redis/redis-py#1496) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Added GET argument to SET command (redis/redis-py#1412) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

implementing the LMOVE and BLMOVE commands (redis/redis-py#1504) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

MINID and LIMIT support for xtrim (redis/redis-py#1508) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Adding support for CLIENT LIST with ID (redis/redis-py#1505) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Zunion (redis/redis-py#1512) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Migrating commands to a mixin (redis/redis-py#1534) * Fixes #1136 * Added typing.py to store type annotations Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Use Version instead of StrictVersion since distutils is deprecated. (redis/redis-py#1552) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

for more information, see https://pre-commit.ci

…dis-py)

lgtm-com · 2022-01-03T02:12:25Z

This pull request introduces 6 alerts and fixes 4 when merging 4c97fd7 into 56d6b32 - view on LGTM.com

new alerts:

2 for Conflicting attributes in base classes
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for Modification of parameter with default
1 for Module is imported with 'import' and 'import from'

fixed alerts:

1 for Multiple calls to `__init__` during object initialization
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for First argument to super() is not enclosing class

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Andrew-Chen-Wang · 2022-01-03T03:58:17Z

Was only needed for figuring out what was wrong. Turns out, test_json that I modified it to was not correct and some test cases were commented out on redis-py

lgtm-com · 2022-01-03T04:05:31Z

This pull request introduces 6 alerts and fixes 4 when merging 817e9b0 into 56d6b32 - view on LGTM.com

new alerts:

2 for Conflicting attributes in base classes
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for Modification of parameter with default
1 for Module is imported with 'import' and 'import from'

fixed alerts:

1 for Multiple calls to `__init__` during object initialization
1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for First argument to super() is not enclosing class

Andrew-Chen-Wang added 30 commits October 4, 2021 15:29

Add redis/redis-py@cb97b9b

d37bb21

changing unit tests to account for defaults in redis flags redis/redis-py#1499 * This does not include the changes in tests/test_pubsub.py because we do not implement threading. Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@9ce7bb2

68a7de7

Add support for COPY command new in Redis 6.2 (redis/redis-py#1492) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@3c244af

a389184

getex (redis/redis-py#1515) * Removed small doc saying all time parameters can be datetime.timedelta. This is not needed with typing and can also be confusing with PXAT and EXAT Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@ad4779e

b7ede71

client_list (redis/redis-py#1517) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@627db54

e41b41c

hrandfield (redis/redis-py#1513) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@57cf7ff

0c3d2ba

NOMKSTREAM support for XADD (redis/redis-py#1507) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@88e5bd8

1829beb

support for client unpause (redis/redis-py#1512) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@b021f5a

d1bed29

Implements CLIENT KILL laddr filter (redis/redis-py#1506) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@01b96db

5cb5a3b

getdel (redis/redis-py#1514) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@e706445

0baf344

zrandmember (redis/redis-py#1519) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@53fe4d3

10f2435

zrangestore (redis/redis-py#1521) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@fc69bd6

eb6c66d

zdiff and zdiffstore (redis/redis-py#1518) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@be26730

d323846

ensuring we adhere to exlusive options for getex (redis/redis-py#1531) * Also fixed type annotation for name to be KeyT Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@e9c2e45

dde66f3

Word was repeated in documentation (redis/redis-py#1532) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@6f4ee2d

57a21bb

zinter (redis/redis-py#1520) * Made some adjustments to typing in _zaggregate Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@3c0e116

82e74e6

exclusive gt and lt in zadd (redis/redis-py#1533) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@ec89d30

2773c34

fix getex flaky tests (redis/redis-py#1537) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@5240d60

293d90f

Updating base testing docker to redis 6.2.5 (redis/redis-py#1536) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@238f69e

961da8c

Add a count parameter to lpop/rpop for redis >= 6.2.0 (redis/redis-py#1487) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@9c60670

af9f1c7

add idle to xpending (redis/redis-py#1523) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@8c4fc80

c5e63df

Fix some typos. (redis/redis-py#1496) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@2789f08

86473fd

Added GET argument to SET command (redis/redis-py#1412) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@37e7c09

05eef1f

implementing the LMOVE and BLMOVE commands (redis/redis-py#1504) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@e498182

30e2082

MINID and LIMIT support for xtrim (redis/redis-py#1508) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@161774b

3bef54d

Adding support for CLIENT LIST with ID (redis/redis-py#1505) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@8c82e42

b6c8416

Zunion (redis/redis-py#1512) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@8ea26c4

94e2b06

Migrating commands to a mixin (redis/redis-py#1534) * Fixes #1136 * Added typing.py to store type annotations Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Add redis/redis-py@8ea26c4

d11ecd9

Use Version instead of StrictVersion since distutils is deprecated. (redis/redis-py#1552) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

pre-commit-ci bot and others added 21 commits October 8, 2021 17:09

[pre-commit.ci] auto fixes from pre-commit.com hooks

5217680

for more information, see https://pre-commit.ci

Patch missed changes in commands.py

a867a34

Patch port for Sentinel.execute_command() to be async

7744a83

Fix most broken tests (add in awaits, etc).

3b61170

Merge branch 'master' into redis-update

4c54b8a

[pre-commit.ci] auto fixes from pre-commit.com hooks

c3fa5dc

for more information, see https://pre-commit.ci

Allow mypy to fail in CI

a767650

Appease the linter and fix a bunch of imports.

e3a784c

Drop support for py3.6 and only test on 6.2 (same redis version as re…

5ac2d8d

…dis-py)

Bump version to 3.0

b7dc6bd

Bump pypy versions in CI

af6046e

Fix matrix exclusions

6fd33b0

Fix remaining tests.

59e0eb4

Fast-forward core to redis/redis-py@4e9cc015

e9bb720

Add docker-compose.yml which includes redis-modules container.

cc87168

Drop large-file check.

4db8d20

Fast-forward tests to redis/redis-py@4e9cc015

4b2fcca

Update CI to include redismodules deployment.

c8f2074

Fix search port.

0d7d1f5

Add custom marker

18ea639

Merge branch 'master' into redis-update

4c97fd7

Andrew-Chen-Wang added the enhancement label Jan 3, 2022

psf-chronographer bot added the bot:chronographer:provided label Jan 3, 2022

Andrew-Chen-Wang marked this pull request as draft January 3, 2022 02:11

Update test_json tests and revert some of my changes

817e9b0

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Andrew-Chen-Wang closed this Jan 3, 2022

Andrew-Chen-Wang deleted the redis-update-2 branch January 3, 2022 03:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redis update #1262

Redis update #1262

Andrew-Chen-Wang commented Jan 3, 2022 •

edited by markdownify bot

lgtm-com bot commented Jan 3, 2022

Andrew-Chen-Wang commented Jan 3, 2022

lgtm-com bot commented Jan 3, 2022

Redis update #1262

Redis update #1262

Conversation

Andrew-Chen-Wang commented Jan 3, 2022 • edited by markdownify bot

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

lgtm-com bot commented Jan 3, 2022

Andrew-Chen-Wang commented Jan 3, 2022

lgtm-com bot commented Jan 3, 2022

Andrew-Chen-Wang commented Jan 3, 2022 •

edited by markdownify bot