Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using gradle defined by spring project #3530

Merged
merged 1 commit into from Apr 6, 2022
Merged

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Apr 4, 2022

Instead of manually setup gradle by test.properties we should use the gradle wrapper set up by project itself. Also update to v2.6.6.

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Apr 4, 2022

jdk11: https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/613/
jdk8: https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/612/

Failure Compilation with Kotlin compile daemon was not successful believe it's the compatibility issue with Kotlin 1.6.10

Gradle is tested with Kotlin 1.3.72 through 1.6.0, not 1.6.10.
1.6.10 has fixes with 1.6.0 https://kotlinlang.org/docs/releases.html#release-details

Could manually edit Kotlin 1.6.10 to be 1.6.0 and see if the problem stays.

jdk 17: https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/610/

Failure General error during semantic analysis: Unsupported class file major version 61 shows the tag '2.6.6' setting gradle 6.9.2, which doesn't work with jdk17.

Disable project with jdk17

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo
Copy link
Contributor Author

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sophia-guo

@llxia llxia merged commit bde273b into adoptium:master Apr 6, 2022
@smlambert
Copy link
Contributor

Thanks!

I will also make the explicit statement here so it can be referenced that updating to v2.6.6 also upgrades to Spring Framework 5.3.18 (spring-projects/spring-boot#30492) (as indicated at: https://github.com/spring-projects/spring-boot/releases/tag/v2.6.6 see Dependency Upgrades). This addresses any concerns that arise in light of the Spring4Shell CVE (as per https://spring.io/blog/2022/03/31/spring-framework-rce-early-announcement#suggested-workarounds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants