New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using gradle defined by spring project #3530
Conversation
jdk11: https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/613/ Failure Gradle is tested with Kotlin 1.3.72 through 1.6.0, not 1.6.10. Could manually edit Kotlin 1.6.10 to be 1.6.0 and see if the problem stays. jdk 17: https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/610/ Failure |
Disable project with jdk17 Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The newest grinder link with v2.6.6 should be https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/617/console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sophia-guo
Thanks! I will also make the explicit statement here so it can be referenced that updating to v2.6.6 also upgrades to Spring Framework 5.3.18 (spring-projects/spring-boot#30492) (as indicated at: https://github.com/spring-projects/spring-boot/releases/tag/v2.6.6 see Dependency Upgrades). This addresses any concerns that arise in light of the Spring4Shell CVE (as per https://spring.io/blog/2022/03/31/spring-framework-rce-early-announcement#suggested-workarounds). |
Instead of manually setup gradle by test.properties we should use the gradle wrapper set up by project itself. Also update to v2.6.6.
Signed-off-by: Sophia Guo sophia.gwf@gmail.com