Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check gradle version of external test projects as only 7.3 supports jdk17 #3510

Open
sophia-guo opened this issue Mar 29, 2022 · 6 comments
Assignees
Labels
Projects

Comments

@sophia-guo
Copy link
Contributor

There are a few external test projects are using gradle with specific version, which might not support jdk17 yet. https://docs.gradle.org/current/userguide/compatibility.html. Need to double check that and if that's the case we need to disable test with jdk17.

Similar to #3381

@amir-waheed
Copy link
Contributor

Can I have this issue assigned to me?

@sophia-guo
Copy link
Contributor Author

Spring : #3505 (comment)

@amir-waheed
Copy link
Contributor

@sophia-guo
These are all the test that require specific version of grade which doesn't support jdk17.
functional-test - gradle version 5.1
Kafta - gradle version 5.4
Spring - gradle version 5.1
system-test - gradle version 5.1
Should I go ahead and disable these tests for jdk17?

@sophia-guo
Copy link
Contributor Author

@amir-waheed we can leave functional-test and system-test as is for now.
Both Spring and Kafta actually use gradle wrapper, which means we don't need to manually setup gradle in test.properties file, please see #3530 as spring updates. You can try similar thing for Kafta.

@sophia-guo
Copy link
Contributor Author

@amir-waheed I also think we can just remove the function print_gradle_install in dockerfile_function.sh as all gradle related projects set up the gradle by gradle wrapper, which we will always use the same gradle version as the application community.

@amir-waheed
Copy link
Contributor

@sophia-guo I have a PR up with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
CanOSP W21
Awaiting triage
Development

No branches or pull requests

2 participants