Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalPlugins parameter to getOctokit method #1181

Merged
merged 2 commits into from Sep 22, 2022

Conversation

luketomlinson
Copy link
Contributor

This allows clients to configure their Octokit/Github instance with OctoKit plugins. This is a variadic parameter, so it should not break existing calls to getOctokit

@luketomlinson luketomlinson marked this pull request as ready for review September 21, 2022 19:03
@luketomlinson luketomlinson requested a review from a team as a code owner September 21, 2022 19:03
packages/github/src/github.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luketomlinson luketomlinson merged commit 94de2cf into main Sep 22, 2022
@luketomlinson luketomlinson deleted the github-with-plugins branch September 22, 2022 20:44
awendt added a commit to babbel/assign-to-repository-projects that referenced this pull request Mar 11, 2024
We shouldn't have to do this:

Using github.getOctokit from @github/actions directly instead of using
its dependency, @octokit/core, would be preferable here.

But it turns out getOctokit cannot be used with the paginateGraphql
plugin, despite actions/toolkit#1181
(I couldn't get it to work).
awendt added a commit to babbel/assign-to-repository-projects that referenced this pull request Mar 11, 2024
We shouldn't have to do this:

Using github.getOctokit from @actions/github directly instead of using
its dependency, @octokit/core, would be preferable here.

But it turns out getOctokit cannot be used with the paginateGraphql
plugin, despite actions/toolkit#1181
(I couldn't get it to work).
awendt added a commit to babbel/sync-repository-projects that referenced this pull request Mar 14, 2024
We shouldn't have to do this:

Using github.getOctokit from @actions/github directly instead of using
its dependency, @octokit/core, would be preferable here.

But it turns out getOctokit cannot be used with the paginateGraphql
plugin, despite actions/toolkit#1181
(I couldn't get it to work).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants