Skip to content

Commit

Permalink
Disable ESLint rule for @octokit/core
Browse files Browse the repository at this point in the history
We shouldn't have to do this:

Using github.getOctokit from @actions/github directly instead of using
its dependency, @octokit/core, would be preferable here.

But it turns out getOctokit cannot be used with the paginateGraphql
plugin, despite actions/toolkit#1181
(I couldn't get it to work).
  • Loading branch information
awendt committed Mar 14, 2024
1 parent e16d0de commit 3555d39
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion __tests__/apiwrapper.js
@@ -1,4 +1,4 @@
import { Octokit } from '@octokit/core';
import { Octokit } from '@octokit/core'; // eslint-disable-line import/no-extraneous-dependencies
import { paginateGraphql } from '@octokit/plugin-paginate-graphql';

import { graphql, HttpResponse } from 'msw'; // https://mswjs.io/docs/getting-started/mocks/graphql-api
Expand Down
2 changes: 1 addition & 1 deletion __tests__/integration.js
@@ -1,4 +1,4 @@
import { Octokit } from '@octokit/core';
import { Octokit } from '@octokit/core'; // eslint-disable-line import/no-extraneous-dependencies
import { paginateGraphql } from '@octokit/plugin-paginate-graphql';

import { graphql, HttpResponse } from 'msw'; // https://mswjs.io/docs/getting-started/mocks/graphql-api
Expand Down
2 changes: 1 addition & 1 deletion index.js
@@ -1,7 +1,7 @@
import core from '@actions/core';
import github from '@actions/github';

import { Octokit } from '@octokit/core';
import { Octokit } from '@octokit/core'; // eslint-disable-line import/no-extraneous-dependencies
import { paginateGraphql } from '@octokit/plugin-paginate-graphql';

import { ApiWrapper } from './apiwrapper.js'; // eslint-disable-line import/extensions
Expand Down

0 comments on commit 3555d39

Please sign in to comment.