Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for v4 #510

Merged
merged 9 commits into from Jul 14, 2021
Merged

Prep for v4 #510

merged 9 commits into from Jul 14, 2021

Conversation

luketomlinson
Copy link
Collaborator

@luketomlinson luketomlinson commented Jun 16, 2021

Changes

  • Create dist for changes
  • Create changelog

@luketomlinson luketomlinson requested a review from a team as a code owner June 16, 2021 21:15
@luketomlinson
Copy link
Collaborator Author

@C0ZEN FYI ☝️

@luketomlinson
Copy link
Collaborator Author

@C0ZEN The standard-version tool didn't work as well as I'd hoped. You have to be pretty strict about following the commit convention and we haven't been. So this changelog is manual

@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 16, 2021

@luketomlinson at least on my side I think my PR titles are good but yeah, every tool is about having a strict syntax.
If you want to enforce it, there are actions that could simply check the PR titles and mark as fail the check if not OK.

@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 16, 2021

@luketomlinson is it WIP?

@flaxel
Copy link
Contributor

flaxel commented Jun 17, 2021

@C0ZEN The standard-version tool didn't work as well as I'd hoped. You have to be pretty strict about following the commit convention and we haven't been. So this changelog is manual

Oh that's probably because of my commits. I didn't find any comments on the commit messages, which is why I didn't pay attention. Would it make sense to write a comment in the contributing file how to name the pull requests?

@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 17, 2021

@flaxel dunno.
The right place for this would be the contributing file, but in fact we just don't care about people commits.
Only the PR title matters and for this, I really think a bot like https://github.com/zeke/semantic-pull-requests would be perfect.

@flaxel
Copy link
Contributor

flaxel commented Jun 17, 2021

An action such as action-semantic-pull-request could also be used if it is not intended to be an app.

CHANGELOG.md Outdated Show resolved Hide resolved
@flaxel flaxel mentioned this pull request Jun 18, 2021
1 task
@flaxel
Copy link
Contributor

flaxel commented Jun 24, 2021

@luketomlinson When do you think you can release the new version?

@luketomlinson
Copy link
Collaborator Author

@flaxel @C0ZEN I wanted to see if we should get #508 in since it is a breaking change.

@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 24, 2021

@luketomlinson I don't think so because actually, I still didn't find the way to implement it.

Copy link
Contributor

@C0ZEN C0ZEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luketomlinson dunno if you are waiting an approval, so I made a final review and voilà ;)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
# Changelog
Starting in version 4.0.0 we will maintain a changelog

## [4.0.0](https://github.com/actions/stale/compare/v3.0.19...v4.0.0) (2021-06-18)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [4.0.0](https://github.com/actions/stale/compare/v3.0.19...v4.0.0) (2021-06-18)
## [4.0.0](https://github.com/actions/stale/compare/v3.0.19...v4.0.0) (2021-06-27)

CHANGELOG.md Outdated Show resolved Hide resolved
@C0ZEN
Copy link
Contributor

C0ZEN commented Jul 9, 2021

@luketomlinson any news?

luketomlinson and others added 7 commits July 14, 2021 09:22
Co-authored-by: Geoffrey Testelin <geoffrey.testelin@gmail.com>
Co-authored-by: Geoffrey Testelin <geoffrey.testelin@gmail.com>
Co-authored-by: Geoffrey Testelin <geoffrey.testelin@gmail.com>
Co-authored-by: Geoffrey Testelin <geoffrey.testelin@gmail.com>
Co-authored-by: Geoffrey Testelin <geoffrey.testelin@gmail.com>
@luketomlinson luketomlinson merged commit cdf15f6 into main Jul 14, 2021
@luketomlinson luketomlinson deleted the prep-for-v4 branch July 14, 2021 14:21
@jasongrout jasongrout mentioned this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants