Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(config): add pr title linting #513

Closed
wants to merge 2 commits into from

Conversation

flaxel
Copy link
Contributor

@flaxel flaxel commented Jun 18, 2021

Changes

Context

The titles of the pull requests are not correct in order to generate the changelog automatically. All types of changes from the specification are allowed.

#510 (comment)

@flaxel flaxel requested a review from a team as a code owner June 18, 2021 15:51
Copy link
Contributor

@C0ZEN C0ZEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me regarding one thing: you can use a "!" to declare a breaking change.

.github/workflows/linting.yml Outdated Show resolved Hide resolved
.github/workflows/linting.yml Outdated Show resolved Hide resolved
.github/workflows/linting.yml Outdated Show resolved Hide resolved
.github/workflows/linting.yml Show resolved Hide resolved
@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 18, 2021

Funny because your PR title is not good based on your proposition ;)

@flaxel
Copy link
Contributor Author

flaxel commented Jun 18, 2021

Funny because your PR title is not good based on your proposition ;)

Why do you think so?

@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 18, 2021

The "types" refer to the white-list of types that you can use, right? In that case, you didn't include "ci".

@flaxel
Copy link
Contributor Author

flaxel commented Jun 18, 2021

If the types are not declared, all those described in the specification are taken by default.

@luketomlinson
Copy link
Collaborator

@flaxel @C0ZEN I am leaning against this and possibly backing out the standard-version changes too. I think it introduces more friction than value, IMO.

@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 24, 2021

@luketomlinson since I am not the one making the release, honestly it's whatever you prefer.
The only important point for me is to just have a good changelog because I really think it's helpful and valuable.

@luketomlinson
Copy link
Collaborator

Thanks for the PR @flaxel. I think I am going to lean way from opinionated stuff like this as I think it introduces more friction than benefit in this case.

@flaxel flaxel deleted the add-pr-title-linting branch July 14, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants