New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(config): add pr title linting #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me regarding one thing: you can use a "!" to declare a breaking change.
Funny because your PR title is not good based on your proposition ;) |
Why do you think so? |
The "types" refer to the white-list of types that you can use, right? In that case, you didn't include "ci". |
If the types are not declared, all those described in the specification are taken by default. |
@luketomlinson since I am not the one making the release, honestly it's whatever you prefer. |
Thanks for the PR @flaxel. I think I am going to lean way from opinionated stuff like this as I think it introduces more friction than benefit in this case. |
Changes
Context
The titles of the pull requests are not correct in order to generate the changelog automatically. All types of changes from the specification are allowed.
#510 (comment)