Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog text issue #528

Closed
jasongrout opened this issue Jul 14, 2021 · 0 comments · Fixed by #531
Closed

Changelog text issue #528

jasongrout opened this issue Jul 14, 2021 · 0 comments · Fixed by #531
Labels
bug Something isn't working

Comments

@jasongrout
Copy link

Describe your issue

In the changelog PR at #510, it says

The options skip-stale-issue-message and skip-stale-pr-message were removed. Instead, setting the options stale-issue-message and stale-pr-message will be enough to let the stale workflow add a comment. If the options are unset, a comment will not be added which was the equivalent of setting skip-stale-issue-message to false.

Should that last word be true? Not adding a comment (IIRC) is equivalent to setting skip-stale-issue-message to true?
@jasongrout jasongrout added the bug Something isn't working label Jul 14, 2021
@jasongrout jasongrout changed the title Changelog issue Changelog text issue Jul 14, 2021
@flaxel flaxel mentioned this issue Jul 15, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(changelog): adapt config description flaxel/stale
1 participant
@jasongrout