Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @actions/core to 1.10.0 #587

Merged

Conversation

rentziass
Copy link
Member

This updates @actions/core to use the file version of save-state and
set-output workflow commands.

@rentziass rentziass requested a review from a team October 6, 2022 11:13
@giordano
Copy link

Would fix #589

@rentziass rentziass force-pushed the rentziass/update-actions-core branch from acdbac6 to 64ebb19 Compare October 12, 2022 16:00
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add process.env['GITHUB_OUTPUT'] = ''; in beforeEach for installer.test.ts

.github/workflows/build-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-test.yml Outdated Show resolved Hide resolved
@rentziass rentziass force-pushed the rentziass/update-actions-core branch from e0b6539 to 742e43f Compare October 13, 2022 09:38
@rentziass
Copy link
Member Author

Thank you @dmitry-shibanov! It was end of day and I couldn't wrap my head around that failure, nor could reproduce it locally 😄 Reverted all the unnecessary changes I was using to debug this in my fork.

@dmitry-shibanov
Copy link
Contributor

Thank you @dmitry-shibanov! It was end of day and I couldn't wrap my head around that failure, nor could reproduce it locally 😄 Reverted all the unnecessary changes I was using to debug this in my fork.

You're welcome. I'm going to merge your pull request. Falling for yarn 1 is not related to your changes.

Copy link

@randydwhitephotography randydwhitephotography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signed-off-by Randy D White randydwhite@randydwhite.com

@randydwhitephotography
Copy link

signed-off-by Randy D White randydwhite@randydwhite.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants