Add dist-check workflow #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions/ Signed-off-by: Fran Mulero <fmulero@vmware.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
gdelgadot
approved these changes
Oct 27, 2022
|
A bit confused here, I think that is the same approach we are following today. The only difference I can spot (apart from the cache, which I'm not sure if we need) is that when the diff fails a new artifact gets uploaded. |
|
You right, I didn't see that validation, so this PR is not adding any value. To be honest having the Thanks @mpermar I am going to close the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fran Mulero fmulero@vmware.com
Description of the change
Follow the same approach as in https://github.com/actions/ with the
distfolder. Users has to maintain that folder and the workflow checks the contentAdditional information
Execution example: fmulero#1