New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation tidyup/updates #993
Conversation
Should I reorder JSDoc? |
Turns out some of the events typings are incorrect, I'm going through them now |
The following properties are missing from index.d.ts for
|
This could go in this PR too: ~Shard.js:1625 |
An update for webhooks returning Message<GuildTextableChannel> can be shoved in, considering webhooks only exist in guilds |
That's already been done |
need |
@DonovanDMC pr on bsian's fork for free pr :) |
true true (done that 👍) |
@DonovanDMC btw it's File changes (whatever the last tab is called), go to index.d.t.s and find OldGuildChannel, then click on the blue "+" and click on that small file icon - it should load the text input with a codeblock prefixed |
* change OldGuildChannel.position from string to number * fix typo in rawREST event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This better work
Co-authored-by: jtsshieh <27078349+jtsshieh@users.noreply.github.com> Co-authored-by: Donovan Daniels <dwddaniels262@gmail.com> Co-authored-by: Geo <georgej1088@gmail.com>
Continuation of #957 (or rather another attempt)
See here for old stuff
I haven't done JSDoc this time round, however have done the structure changes:From inside the namespace, the order is as follows)
Each category has 2 newline separations, with each group, or each class with a single newline separation
I'll also fill in missing docs for JSDoc
Invite.guild also now gets the relevant guild
Invite.channel now gets the relevant guild channel if the guild is cached. if group channel or not cached this will still be an object
(note for abal, please don't merge this with the other PRs since there's bound to be conflicts once the other PRs get merged)
Documentation/codebase layout changes
userID
parameter for messageReactionAdd and messageReactionRemove for DMs (Anything other than "@me" will error)TypeScript v4
Warning may be shown in the console of the CI, this can be disregarded, see here
Resolves #1003
Resolves #1004