Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove userID from addReaction #1020

Closed
wants to merge 1 commit into from
Closed

Remove userID from addReaction #1020

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2020

This removes the userID parameter from addReaction/addMessageReaction.

  • it can be confusing for users ("do I put my client user ID there?")
  • this endpoint cannot be used with anything other than the constant text @me, so there is no need for user input here.

alex-taxiera
alex-taxiera approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@alex-taxiera alex-taxiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typings look good

@bsian03
Copy link
Collaborator

bsian03 commented Sep 21, 2020

I deprecated this in #993 already

@ghost
Copy link
Author

ghost commented Sep 21, 2020

oh

@ghost ghost closed this Sep 21, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bsian03 @alex-taxiera @abalabahaha