Add Theme Previews for block themes #50030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
commented
Apr 24, 2023
|
Size Change: +694 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
scruffian
commented
Apr 24, 2023
Mamaduka
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Hi, @scruffian
Can you provide more context why the new middleware is needed? It seems that new middleware will be applied to every request. Do you think that's necessary?
The PHP code could use notes on how it's meant to be migrated into the core. We should move the feature into the experimental directory if it is still experimental. The former isn't a requirement, but I found it helpful when migrating the code to the WP core.
|
Flaky tests detected in c08950a0e159cb452a99d97c113bca0a96514f7e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4819963070
|
getdave
reviewed
Apr 26, 2023
getdave
reviewed
Apr 26, 2023
getdave
reviewed
Apr 26, 2023
getdave
reviewed
Apr 26, 2023
scruffian
commented
Apr 27, 2023
@Mamaduka it will only be applied on the requests when |
ajlende
force-pushed
the
add/theme-previews
branch
from
c08950a
to
f220ff3
Compare
scruffian
force-pushed
the
add/theme-previews
branch
3 times, most recently
from
2202a6e
to
28472cd
Compare
draganescu
approved these changes
Apr 28, 2023
make it work for child themes sanitize the theme_preview param use the url package move to middleware make a serverside middleware add comment remove comment change url add comments add the theme previews file rename param remove unsed params fix PHPCS Add live preview buttons to block themes partly update the editor to reflect that theme preview is on keep the preview flag on when navigating through pages activate theme from the preview add an experiment add default stylesheet hide behind and experiment Update lib/experiments-page.php Co-authored-by: Dave Smith <getdavemail@gmail.com> Update lib/experiments-page.php Co-authored-by: Dave Smith <getdavemail@gmail.com> Update lib/experiments-page.php Co-authored-by: Dave Smith <getdavemail@gmail.com> linting and docs add a snackbar notice Translate script strings Render theme name instead of path Update packages/edit-site/src/components/save-hub/index.js Use @wordpress/url utils show button on all block themes even after scrolling Update site editor save button to activate theme Fix activate buttons to remove url param Replace history instead of pushing only activate themes when saving dirty changes move functions to utils move activate to a hook add a return url use getQueryArgs Refactor save hub activate and save button add warning about theme activation Co-authored-by: Dave Smith <444434+getdave@users.noreply.github.com> rename function fix rebase fix PHPCS fix the experiment name wrap changes in an experiment
|
There are a few things we need to do before this can move outside of an experiment:
|
|
I have used the super power and merged this with one failing test: in |
priethor
added
[Feature] Themes
|
I may be reading this wrong, but it seems like any visitor to the site can override the theme being used by passing |
|
Very cool. |
We have an issue for this: #50188 |
This was referenced May 23, 2023
15 tasks
This was referenced Jun 5, 2023
8 tasks
This was referenced Jul 11, 2023
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds theme previews to the Site Editor by means of a
theme_previewparameter. The aim is to enable theme previews from the theme directory as outlined in #37201 (comment).🤖 Generated by Copilot at 3f68df7
This pull request adds a new feature to the
apiFetchandcore-datapackages that enables theme previews in the Site Editor for block themes. It also adds a compatibility layer for WordPress 6.3 that filters the blog options and sets the theme for the preview based on the REST API request. It creates and requires a new filetheme-previews.phpand a new middleware functioncreateThemePreviewMiddleware.Why?
Theme previews are a missing feature for block themes.
How?
stylesheetandtemplateoptions when thetheme_previewURL parameter is set, to modify the blog option for to a different theme.🤖 Generated by Copilot at 3f68df7
theme-previews.phpfile in theload.phpfile (link)createThemePreviewMiddlewarefunction in theapi-fetchpackage (link,link,link)__experimentalGetTemplateForLinkresolver function in thecore-datapackage (link)theme_previewparameter to the fetch request, based on the value of thetheme_previewGET parameter in the window location (link)Testing Instructions
themePathis the relative path to the theme you want to preview (e.g.twentytwentythree).Testing Instructions for Keyboard
Screenshots or screencast
Todo
Fixes #37201 and #47228
@WordPress/block-themers