Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the “Live Preview” button on the Theme Detail page #79218

Closed
5 of 6 tasks
okmttdhr opened this issue Jul 11, 2023 · 1 comment
Closed
5 of 6 tasks

Add the “Live Preview” button on the Theme Detail page #79218

okmttdhr opened this issue Jul 11, 2023 · 1 comment
Assignees

Comments

@okmttdhr
Copy link
Member

okmttdhr commented Jul 11, 2023

Description

We're to add the “Live Preview” button on the Theme Detail page to bring Block Theme Previews to dotcom. See pbxlJb-3Uv-p2 for more detail.

We have the UI in the comment, but we need to review the copy of "Open live demo" to avoid confusion with "Live Preview".

We can use some of the same code as we do in #79219.

Acceptance Criteria

  • We can navigate users to the Live Preview from the Theme Detail page

Dev Tasks

Testing

  • Go to the Theme Detail page
  • Make sure the button is shown/hidden
  • Make sure the link in the button works

Related

@okmttdhr
Copy link
Member Author

okmttdhr commented Aug 3, 2023

We need to review the copy of the "Open live demo" to avoid confusion with the "Live Preview"

I'm closing this issue, as we can address this in #80134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant