[Block Editor]: Lock blockInspectorAnimation setting
#47740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
draganescu,
adamziel,
Mamaduka,
scruffian,
getdave and
artemiomorales
ntsekouras
requested review from
TimothyBJacobs,
spacedmonkey,
geriux,
ellatrix and
tellthemachines
as code owners
ntsekouras
changed the title
blockInspectorAnimation setting
|
Size Change: +65 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 42cf442. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4085045934
|
|
Thanks for putting this together. I’ll defer to @scruffian and @getdave on whether removing the setting for the navigation, navigation link, and navigation submenu is the right move, but this looks good to me. |
I'm not removing them. This PR lock's the editor setting with the previous blocks as default values for the setting. |
draganescu
previously requested changes
Feb 3, 2023
Does this work in trunk right now? From the code it seems it worked only for these three blocks. |
adamziel
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
@ntsekouras privacy-wise it looks good to me. I'll defer to @draganescu on the nav block functionality.
draganescu
deleted the
lock/__experimentalBlockInspectorAnimation-setting
branch
ntsekouras
added a commit
that referenced
this pull request
Feb 7, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #47196
Locks
__experimentalBlockInspectorAnimation(introduced here) and renames it toblockInspectorAnimation.Testing Instructions