Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All navigation block children should be animated #47784

Closed
draganescu opened this issue Feb 6, 2023 · 2 comments · Fixed by #47834
Closed

All navigation block children should be animated #47784

draganescu opened this issue Feb 6, 2023 · 2 comments · Fixed by #47834
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

draganescu commented Feb 6, 2023

Starting with #46342 and continued in #47740 the navigation block's block inspector tree editing has an animation whenever children need specific settings and are activated via clicking them in the tree.

In #47740 it became apparent that only links and submenus animate the inspector upon selection. We should enable the animation for all blocks that are allowed as inner blocks of the navigation block.

In the video below notice when clicking on social links the inspector incoming does not animate on enter

animation-navigation.mp4
@draganescu draganescu added the [Type] Enhancement A suggestion for improvement. label Feb 6, 2023
@getdave
Copy link
Contributor

getdave commented Feb 6, 2023

I didn't know anything was animated 😄

Would love a video to illustrate here if you have time...

@draganescu
Copy link
Contributor Author

@getdave

animate the inspector upon selection

there is an animation of entry when the inspectors for links and submenus are shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants