Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FocalPointPicker: Fix layout misalignment when placed in the BlockInspector #46631

Merged
merged 6 commits into from Dec 21, 2022
Merged

FocalPointPicker: Fix layout misalignment when placed in the BlockInspector #46631

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea3d758
FocalPointPicker: Reset margin-bottom of UnitControl to align vertica…
t-hamano Dec 18, 2022
e63d6d3
Update changelog
t-hamano Dec 18, 2022
385fc5d
Apply fixes to the `BlockInspector` component
t-hamano Dec 20, 2022
87accf9
Move changelog into block-editor package
t-hamano Dec 20, 2022
11a6814
Merge branch 'trunk' into focalpointpicker-align-items
t-hamano Dec 20, 2022
38b6b72
Merge branch 'trunk' into focalpointpicker-align-items
t-hamano Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@
- `InputControl`: Fix internal `Flex` wrapper usage that could add an unintended `height: 100%` ([#46213](https://github.com/WordPress/gutenberg/pull/46213)).
- `Navigator`: Allow calling `goTo` and `goBack` twice in one render cycle ([#46391](https://github.com/WordPress/gutenberg/pull/46391)).
- `Modal`: Fix unexpected modal closing in IME Composition ([#46453](https://github.com/WordPress/gutenberg/pull/46453)).
- `FocalPointPicker`: Reset `margin-bottom` of `UnitControl` to align vertical position ([#46631](https://github.com/WordPress/gutenberg/pull/46631)).
Copy link
Contributor Author

@t-hamano t-hamano Dec 18, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR a bug fix? Maybe it is 'internal' or 'enhancement'...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would classify it as a bug fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved the changelog entry to the block-editor package.


### Enhancements

Expand Down
4 changes: 4 additions & 0 deletions packages/components/src/focal-point-picker/styles/focal-point-picker-style.ts
View file
Open in desktop
Expand Up @@ -54,6 +54,10 @@ export const MediaPlaceholder = styled.div`

export const StyledUnitControl = styled( UnitControl )`
width: 100px;

&&& {
margin-bottom: 0;
}
`;

const deprecatedBottomMargin = ( {
Expand Down