FocalPointPicker: Fix layout misalignment when placed in the BlockInspector
#46631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Dec 18, 2022
packages/components/CHANGELOG.md
Outdated
| @@ -17,6 +17,7 @@ | |||
| - `InputControl`: Fix internal `Flex` wrapper usage that could add an unintended `height: 100%` ([#46213](https://github.com/WordPress/gutenberg/pull/46213)). | |||
| - `Navigator`: Allow calling `goTo` and `goBack` twice in one render cycle ([#46391](https://github.com/WordPress/gutenberg/pull/46391)). | |||
| - `Modal`: Fix unexpected modal closing in IME Composition ([#46453](https://github.com/WordPress/gutenberg/pull/46453)). | |||
| - `FocalPointPicker`: Reset `margin-bottom` of `UnitControl` to align vertical position ([#46631](https://github.com/WordPress/gutenberg/pull/46631)). | |||
There was a problem hiding this comment.
Is this PR a bug fix? Maybe it is 'internal' or 'enhancement'...
There was a problem hiding this comment.
I would classify it as a bug fix.
There was a problem hiding this comment.
I have moved the changelog entry to the block-editor package.
t-hamano
added
[Feature] Inspector Controls
t-hamano
requested review from
ciampo and
mirka
and removed request for
ajitbohra
|
Should we add the |
|
Mmm, good catch. This one is caused by the problematic override style added in the block-editor package's So yeah @glendaviesnz, the FocalPointPicker itself is already being used with the no-margin prop enabled, but the consumer ( @t-hamano If possible, my preference would be to add any workarounds in the offending consumer package ( |
t-hamano
changed the title
BlockInspector
|
@mirka
|
|
Size Change: +36 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a problem with the unit controls (Left, Top) not being aligned vertically when the
FocalPointPickercomponent is used in the block sidebar (InspectorControls).Why?
The control itself has no margin, but
margin-bottomis applied by theInspectorControl. And this is because the value is smaller in the UnitControl on the right side.How?
I have reset the
margin-bottomon theUnitControl. I believe this is the appropriate approach as this margin is not expected, but if there is another way, please advise.Testing Instructions