Site Editor: Try template drill down on shell sidebar (browse mode) #45100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
16 tasks
oandregal
added
the
[Feature] Site Editor
|
Size Change: -1.41 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
I think the important heuristic to install here is that the active menu item reflects what is visible in the site frame. So there are two options in regards to what happens when you click '< Design':
|
|
Some additional notes:
|
youknowriad
force-pushed
the
try/admin-navigation
branch
2 times, most recently
from
29227cf
to
3f8377e
Compare
stokesman
reviewed
Oct 24, 2022
youknowriad
force-pushed
the
try/admin-navigation
branch
from
b785af7
to
a4841f2
Compare
|
I'm pausing work on this until the base branch this depends on settles a bit. It's more dynamic than I thought when prepared this PR. |
youknowriad
force-pushed
the
try/admin-navigation
branch
4 times, most recently
from
d574492
to
c0aba96
Compare
youknowriad
force-pushed
the
try/admin-navigation
branch
2 times, most recently
from
ab23bb7
to
569315c
Compare
youknowriad
force-pushed
the
try/admin-navigation
branch
5 times, most recently
from
64871fa
to
afd0bd0
Compare
youknowriad
force-pushed
the
try/admin-navigation
branch
2 times, most recently
from
949ad26
to
a94be4c
Compare
|
Good catch the jump appeared when we changed the focus style to 1.5 border, it's now fixed. |
ellatrix
reviewed
Dec 9, 2022
packages/edit-site/src/components/sidebar-navigation-screen-templates/style.scss
Show resolved
Hide resolved
ellatrix
reviewed
Dec 9, 2022
|
I'm also wondering if we can make switching between templates flash the screen less. Would be cool if we could wait for the template to load, then fade it in or something. Anyway, nit picking here. |
|
I also have the feeling that we are re-rendering the whole iframe when switching templates. It doesn't feel smooth. |
ellatrix
approved these changes
Dec 9, 2022
that's a good point, it's not really clear how to implement that, I think this maybe the purpose of useTransition in React 18, we'll have to experiment a bit with these APIs once we enable |
|
One final nit pick... 😄 When I edit a template, and go back to browse, all my context is lost:
|
|
@ellatrix yes see #45100 (comment) and #45100 (comment) |
|
Thanks for your work on this! |
This was referenced Dec 9, 2022
ryanwelcher
changed the title
This was referenced Jan 13, 2023
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is a follow-up to #44770 that implements navigation for templates. The goal is to have something like this:
221018-site-editor-templates-drill-down.mp4
Why?
To explore how it looks like & find potential issues beforehand while controlling scope and implement one small thing at a time.
How?
It builds on #44770 and:
Testing Instructions
Current state
For some reason, my cursor is not recorded:
Gravacao.de.ecra.a.partir.de.01-12-2022.13.24.40.webm
TODO:
In the interest of rapid iteration, we should probably not group templates in this PR, but in a follow-up.