Add e2e tests for Drag-and-Drop in the inserter #44631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Automated Testing
|
Size Change: +1 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
add/e2e-tests-for-inserter-dnd
branch
20 times, most recently
from
d8ad8df
to
e325500
Compare
kevin940726
force-pushed
the
add/e2e-tests-for-inserter-dnd
branch
7 times, most recently
from
9ac2232
to
91bfe4a
Compare
kevin940726
force-pushed
the
add/e2e-tests-for-inserter-dnd
branch
10 times, most recently
from
17275e8
to
bb5f0d3
Compare
kevin940726
commented
Oct 11, 2022
| @@ -49,6 +49,8 @@ | |||
| border-radius: $radius-block-ui; | |||
| opacity: 0.04; | |||
| background: var(--wp-admin-theme-color); | |||
| // This fixes drag-and-drop in Firefox. | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
Reference: #44711 (comment).
Comment on lines
+64
to
+72
| /** | ||
| * Headless webkit won't receive dataTransfer with custom types in the | ||
| * drop event on Linux. The solution is to use `xvfb-run` to run the tests. | ||
| * ```sh | ||
| * xvfb-run npm run test:e2e:playwright | ||
| * ``` | ||
| * See `.github/workflows/end2end-test-playwright.yml` for advanced usages. | ||
| */ | ||
| headless: os.type() !== 'Linux', |
There was a problem hiding this comment.
This is kinda unfortunate for linux developers. I'll try to raise an issue upstream. Maybe we should consider only running chromium tests when developing locally?
There was a problem hiding this comment.
Opened an issue here: microsoft/playwright#18013.
|
Would be good to get CI passing in this PR. I think the problem causing them to fail has been solved in |
kevin940726
force-pushed
the
add/e2e-tests-for-inserter-dnd
branch
from
8f638a4
to
2fbbbc8
Compare
|
Nice job working through the kinks in getting the cross-browser testing in place @kevin940726 👌 Everything tests well for me, changes make sense, and CI is passing. I'm inclined to approve this PR but think it might be better to get the official green light from someone with more expertise in this area. |
talldan
approved these changes
Oct 17, 2022
kevin940726
force-pushed
the
add/e2e-tests-for-inserter-dnd
branch
from
c1ad83c
to
ecb0a43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Close #31356. Add drag-and-drop e2e tests for the global inserter.
This PR also tries to add cross-browser testing with firefox and webkit, powered by Playwright.
Why?
Because more tests = better! It will also make a potential refactor of the drag-and-drop feature easier to implement.
How?
By default, e2e tests are only run in chromium. We can enable testing in firefox and webkit by appending the
@firefoxor@webkittag to the test title. The tag also works intest.describeand will apply to all the nested tests. We can append-firefox,-webkit, or-chromiumto individually disable testing in some browsers.Testing Instructions
CI should pass.