Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluid typography: add configurable settings for minimum font size to theme.json #42489

Merged
merged 15 commits into from Dec 15, 2022
Merged

Fluid typography: add configurable settings for minimum font size to theme.json #42489

merged 15 commits into from Dec 15, 2022

Commits on Dec 15, 2022

  1. Reinstating the commit in edeaca7 so we can test fluid configuration 

    Update docs
    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    632e9b7 View commit details
    Browse the repository at this point in the history

  2. Adding a filter pre-calculations

    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6d14b11 View commit details
    Browse the repository at this point in the history

  3. $fluid_settings was missing

    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    fdf74f1 View commit details
    Browse the repository at this point in the history

  4. Removing filter 

    Pulling across config changes to JS
    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5f2a77a View commit details
    Browse the repository at this point in the history

  5. Add config slot for minFontSize

    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a6533d5 View commit details
    Browse the repository at this point in the history

  6. Adding config to test theme

    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    dcf083e View commit details
    Browse the repository at this point in the history

  7. Updating args to include minimumFontSizeLimit 

    Fixed `typographySettings` check
    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d0f1697 View commit details
    Browse the repository at this point in the history

  8. Updating tests and fixing settings logic 

    Updating schema

Changelogs
    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3b6cd9a View commit details
    Browse the repository at this point in the history

  9. Ensure that a theme's fluid font size settings are used when calculat… 

    …ing custom font sizes and search block font sizes.
    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    4ffc18e View commit details
    Browse the repository at this point in the history

  10. Validating incoming viewport widths and min font size against accepte… 

    …d units.
    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8a3fb8f View commit details
    Browse the repository at this point in the history

  11. Ensure we check for fluid settings validity in getTypographyClassesAn… 

    …dStyles
    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    7775602 View commit details
    Browse the repository at this point in the history

  12. Rolling back configurable values to the global minimum font size only. 

    Updating tests.
    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    642b3c7 View commit details
    Browse the repository at this point in the history

  13. Remove config assignment from getTypographyClassesAndStyles and updat… 

    …ed tests.
    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    dff191d View commit details
    Browse the repository at this point in the history

  14. Adding frontend test for unsupported units in min font size config

    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d9531c2 View commit details
    Browse the repository at this point in the history

  15. simplifying condition so that it's readable in screen widths < 100000px

    @ramonjd
    ramonjd committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a998a1b View commit details
    Browse the repository at this point in the history