Fluid typography: add configurable settings for minimum font size to theme.json #42489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
ramonjd
force-pushed
the
add/block-supports-fluid-fontsize-config
branch
from
dd173b3
to
7076ce9
Compare
ramonjd
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
ramonjd
added
the
[Feature] Typography
ramonjd
commented
Jul 26, 2022
ramonjd
force-pushed
the
add/block-supports-fluid-fontsize-config
branch
from
24bfb63
to
29e3128
Compare
ramonjd
force-pushed
the
add/block-supports-fluid-fontsize-config
branch
from
29e3128
to
5d96ecf
Compare
This was referenced Oct 12, 2022
ramonjd
force-pushed
the
add/block-supports-fluid-fontsize-config
branch
from
5d96ecf
to
8f789fc
Compare
ramonjd
commented
Oct 27, 2022
|
Size Change: +101 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ramonjd
added
[Status] In Progress
This was referenced Nov 3, 2022
ramonjd
force-pushed
the
add/block-supports-fluid-fontsize-config
branch
from
1335b9d
to
3fd570c
Compare
Fixed `typographySettings` check
Updating schema Changelogs
…ing custom font sizes and search block font sizes.
ramonjd
force-pushed
the
add/block-supports-fluid-fontsize-config
branch
from
d4181e4
to
a998a1b
Compare
Closed
6 tasks
85 tasks
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jan 24, 2023
…t_typography_font_size_value(). In `wp_get_typography_font_size_value()`, adds support for using a minimum font size for fluid typography when defined in a theme's `theme.json` file. Reference: * Part of [WordPress/gutenberg#42489 Gutenberg PR 42489] Follow-up to [54497], [54260]. Props andrewserong, ramonopoly, hellofromTonya, joen. Fixes #57529. git-svn-id: https://develop.svn.wordpress.org/trunk@55133 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jan 24, 2023
…t_typography_font_size_value(). In `wp_get_typography_font_size_value()`, adds support for using a minimum font size for fluid typography when defined in a theme's `theme.json` file. Reference: * Part of [WordPress/gutenberg#42489 Gutenberg PR 42489] Follow-up to [54497], [54260]. Props andrewserong, ramonopoly, hellofromTonya, joen. Fixes #57529. Built from https://develop.svn.wordpress.org/trunk@55133 git-svn-id: http://core.svn.wordpress.org/trunk@54666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Jan 24, 2023
…t_typography_font_size_value(). In `wp_get_typography_font_size_value()`, adds support for using a minimum font size for fluid typography when defined in a theme's `theme.json` file. Reference: * Part of [WordPress/gutenberg#42489 Gutenberg PR 42489] Follow-up to [54497], [54260]. Props andrewserong, ramonopoly, hellofromTonya, joen. Fixes #57529. Built from https://develop.svn.wordpress.org/trunk@55133 git-svn-id: https://core.svn.wordpress.org/trunk@54666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
andrewserong
added
the
Needs Dev Note
Dev note for 6.2Note: this feature might not need it's own standalone dev note if it looks like it could be combined with other features, as it's a fairly small feature. Fluid typography minimum font sizeFollowing on from the fluid typography settings that were introduced in WordPress 6.1, WordPress 6.1.1 introduced a hard-coded minimum for the fluid typography rules of In WordPress 6.2, themes can define their own minimum font size for fluid typography rules. Depending on the theme's requirements, sometimes the desired minimum font size value might be greater or less than the provided default of How to use minimum font size in your themeWithin With the The output for a paragraph block set to Related reading
@bph here's a draft dev note for the fluid typography rules changes, I think this PR wasn't listed in the dev notes list, so I'll add it over there, too. This dev note also implicitly covers the changes from #45536, I believe. |
47 tasks
bph
added
has dev note
|
@andrewserong Thank you so much for your notes and updating the tracking issue. I added the Dev Note to the draft Misc Editor post |
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
…t_typography_font_size_value(). In `wp_get_typography_font_size_value()`, adds support for using a minimum font size for fluid typography when defined in a theme's `theme.json` file. Reference: * Part of [WordPress/gutenberg#42489 Gutenberg PR 42489] Follow-up to [54497], [54260]. Props andrewserong, ramonopoly, hellofromTonya, joen. Fixes #57529. Built from https://develop.svn.wordpress.org/trunk@55133 git-svn-id: http://core.svn.wordpress.org/trunk@54666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of
Follows on from #39529 by adding configurable fluid font-size settings.
The first setting to be added is
settings.typography.fluid.minFontSize, which sets the lower bound at which custom font sizes are converted to clamp values.The current, hard-coded value is
14px.Why?
The hard-coded value of
14pxmay not be appropriate for some theme designs.How?
By checking global fluid typography for values.
Testing Instructions
Play with
minFontSizein the fluid config settings (px/rem/em units only) and ensure that custom font sizes are only clamp above the value you set.{ "version": 2, "settings": { "appearanceTools": true, "layout": { "contentSize": "840px", "wideSize": "1100px" }, "typography": { "fluid": { "minFontSize": "16px" } } } }sample editor code
Run the tests!
See also